Re: [Qemu-devel] [PATCH V7 08/13] monitor: refine parse_cmdline()

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 930 bytes --]

On 07/19/2013 07:44 PM, Wenchao Xia wrote:
> Since this function will be used by help_cmd() later, so improve
> it to make it more generic and easier to use. free_cmdline_args()
> is added to as paired function to free the result.

s/added to/added too/

> 
> One change of this function is that, when the valid args in input
> exceed the limit of MAX_ARGS, it fails now, instead of return with
> MAX_ARGS of parsed args in old code. This should not impact much
> since it is rare that user input many args in monitor's "help" and
> auto complete scenario.
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>  monitor.c |   51 ++++++++++++++++++++++++++++++++++++++++-----------
>  1 files changed, 40 insertions(+), 11 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]