From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0rLO-0004so-S7 for qemu-devel@nongnu.org; Sun, 21 Jul 2013 06:58:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0rLN-00039p-QU for qemu-devel@nongnu.org; Sun, 21 Jul 2013 06:58:26 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44471 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0rLN-00039l-H8 for qemu-devel@nongnu.org; Sun, 21 Jul 2013 06:58:25 -0400 Message-ID: <51EBBECA.9020906@suse.de> Date: Sun, 21 Jul 2013 12:58:18 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 00/26] use realizefn for SysBusDevice, part 1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: Kevin Wolf , Peter Crosthwaite , Eduardo Habkost , Stefan Hajnoczi , qemu-devel , Anthony Liguori , Paolo Bonzini , Igor Mammedov Am 01.07.2013 12:18, schrieb Hu Tao: > Hu Tao (26): > sysbus: document SysBusDeviceClass about @init > ohci: QOM'ify some more > ohci: use realize for ohci > i440fx-pcihost: use realize for i440fx-pcihost > i440fx: use type-safe cast instead of directly access of parent dev > q35: use type-safe cast instead of directly access of parent dev > q35: use realize for q35 host > fdc: QOM'ify some more > fdc: use realize for fdc. > pflash-cfi01: QOM'ify some more > pflash_cfi01: use realize for pflash_cfi01 > pflash-cfi02: QOM'ify some more > pflash_cfi02: use realize for pflash_cfi02 > ahci: QOM'ify some more > ahci: use realize for ahci > fwcfg: QOM'ify some more > fwcfg: use realize for fwcfg > scsi esp: QOM'ify some more > scsi esp: use realize for scsi esp > hpet: QOM'ify some more > hpet: use realize for hpet > kvmclock: QOM'ify some more > kvmclock: use realize for kvmclock > kvmvapic realize > ioapic: use realize for ioapic > isa bus: remove isabus_bridge_init since it does nothing By now I believe I've queued all of these, partially with minor changes like b or err-vs.-errp variable renames or replacement of repeated in-place QOM casts with a variable and one bug fix. Most realizefn patches conflicted due to Memory API changes. In two cases I inserted error propagation improvements as indicated. Testing appreciated. git://github.com/afaerber/qemu-cpu.git qom-next https://github.com/afaerber/qemu-cpu/commits/qom-next Regards, Andreas > hw/block/fdc.c | 87 +++++++++++++++++++++++++++++++----------= -------- > hw/block/pflash_cfi01.c | 28 ++++++++-------- > hw/block/pflash_cfi02.c | 31 +++++++++--------- > hw/i386/kvm/clock.c | 15 +++++---- > hw/i386/kvmvapic.c | 12 +++---- > hw/ide/ahci.c | 21 ++++++------ > hw/intc/ioapic_common.c | 12 +++---- > hw/isa/isa-bus.c | 8 ----- > hw/nvram/fw_cfg.c | 36 +++++++++++--------- > hw/pci-host/piix.c | 36 ++++++++++++-------- > hw/pci-host/q35.c | 60 +++++++++++++++++----------------- > hw/scsi/esp.c | 46 ++++++++++++++++---------- > hw/timer/hpet.c | 44 +++++++++++++++---------- > hw/usb/hcd-ohci.c | 32 +++++++++--------- > include/hw/sysbus.h | 10 ++++++ > 15 files changed, 268 insertions(+), 210 deletions(-) --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg