From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38684)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1V14Rg-0007dv-Ox
	for qemu-devel@nongnu.org; Sun, 21 Jul 2013 20:57:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1V14Re-0001i3-JL
	for qemu-devel@nongnu.org; Sun, 21 Jul 2013 20:57:48 -0400
Received: from mail-pd0-f173.google.com ([209.85.192.173]:63795)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1V14Re-0001hn-D6
	for qemu-devel@nongnu.org; Sun, 21 Jul 2013 20:57:46 -0400
Received: by mail-pd0-f173.google.com with SMTP id v14so6212312pde.32
	for <qemu-devel@nongnu.org>; Sun, 21 Jul 2013 17:57:44 -0700 (PDT)
Message-ID: <51EC8381.4020801@ozlabs.ru>
Date: Mon, 22 Jul 2013 10:57:37 +1000
From: Alexey Kardashevskiy <aik@ozlabs.ru>
MIME-Version: 1.0
References: <1374401042-18511-1-git-send-email-aik@ozlabs.ru>
	<1374442491.3916.2.camel@pasglop> <51EC7AC9.3080306@ozlabs.ru>
	<1374452612.3916.17.camel@pasglop>
In-Reply-To: <1374452612.3916.17.camel@pasglop>
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH] spapr-vscsi: add task management
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, Paul Mackerras <paulus@samba.org>, David Gibson <david@gibson.dropbear.id.au>

On 07/22/2013 10:23 AM, Benjamin Herrenschmidt wrote:
> On Mon, 2013-07-22 at 10:20 +1000, Alexey Kardashevskiy wrote:
>> May be. But there was no way to get this callback called till I started
>> calling scsi_req_cancel in this patch so I would not split.
> 
> You probably still should. The smaller each individual patch, the better
> (in part because that makes them easier to review).


Should make it easier but in fact it does not for me :)


> So a first patch adding the new callback, then a second patch adding the
> task management.

I can even add tasks one-by-one :)

Come on, is this patch really big or even close to be called big?


-- 
Alexey