From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH] cifs-utils: Correct max string lengths Date: Mon, 22 Jul 2013 09:38:17 +0800 Message-ID: <51EC8D09.1020504@asianux.com> References: <1374269172-4964-1-git-send-email-scott.lovenberg@gmail.com> <8FB3EB95-C367-4DE7-935C-37C7295F7D53@gmail.com> <20130720064344.42d73b04@tlielax.poochiereds.net> <6D61AEAF-9EE2-4F99-BA76-F186A76312E0@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Jeff Layton , Steve French , "linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org" , "sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org" To: Scott Lovenberg Return-path: In-Reply-To: <6D61AEAF-9EE2-4F99-BA76-F186A76312E0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 07/20/2013 11:24 PM, Scott Lovenberg wrote: > > > Sent from my iPod > > On Jul 20, 2013, at 6:43, Jeff Layton wrote: > >> On Fri, 19 Jul 2013 22:44:22 -0400 >> Scott Lovenberg wrote: >> >>> On Jul 19, 2013, at 22:34, Steve French wrote: >>> >>>> Leaving Max share length at 256 is fine with me >>> Works for me. Should this be fixed kernel side? >> >> Yes, I think that would make sense. Scott, I assume you'll send a v2 of >> this patch that preserves the share length at 256? >> >> Once that's done, the ideal thing here would be to move these >> definitions in the kernel to a separate header file that lives under >> include/linux. Then we could have autoconf in cifs-utils look for that >> header and use the #defines from that instead if it's present. >> >> That way we won't be so reliant on keeping the kernel and cifs-utils in >> sync... > > Yeah. I'll respin and send tomorrow. I have a wedding to attend this afternoon. Using autoconf would be terrific and I'm completely on board with that idea. > Is it better to let the new header file in "include/uapi/linux" ? It belongs to the interface between user mode and kernel mode. >> -- >> Jeff Layton > > Thanks. -- Chen Gang