All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Cherian <george.cherian@ti.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	linux-usb@vger.kernel.org, balbi@ti.com,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
	linux-omap@vger.kernel.org, kishon@ti.com
Subject: Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX
Date: Mon, 22 Jul 2013 11:15:41 +0530	[thread overview]
Message-ID: <51ECC705.2070904@ti.com> (raw)
In-Reply-To: <51EA06EB.4080709@ti.com>

On 7/20/2013 9:11 AM, George Cherian wrote:
> On 7/20/2013 12:12 AM, Sebastian Andrzej Siewior wrote:
>> On 07/19/2013 08:33 PM, Sergei Shtylyov wrote:
>>> Hello.
>> Hello,
>>
>>>> usb: usb@47400000 {
>>>>      compatible = "ti,am33xx-usb";
>>>>           usb0_phy: phy@47401300 {
>>>>          compatible = "ti,am335x-usb-phy";
>>>>      }
>>>>      usb0: usb@47401000 {
>>>>          musb0: usb@47401400 {
>>>>              compatible = "mg,musbmhdrc";
>>>>          }
>>>>      }
>>>>      usb1_phy: phy@47402300 {
>>>>          compatible = "ti,am335x-usb-phy";
>>>>      }
>>>>      usb1: usb@47402000 {
>>>>          musb1: usb@47402400 {
>>>>              compatible = "mg,musbmhdrc";
>>>>          }
>>>>      }
>>>> }

How about something like this ?

Here am making
     wrapper -> musb instance 0 -> phy0
     wrapper -> musb instance 1 -> phy1

                 musb: usb@47400000 {
                         compatible = "ti,musb-am33xx";
                         reg = <0x47400000 0x1000>;
                         ranges;
                         #address-cells = <1>;
                         #size-cells = <1>;
                         interrupts = <17>;
                         ti,hwmods = "usb_otg_hs";

                         usb0@47401000 {
                                 reg = <0x47401000 0x800>;
                                 interrupts = <18>;
                                 interrupt-names = "mc";
                                 multipoint = <1>;
                                 num-eps = <16>;
                                 ram-bits = <12>;
                                 port-mode = <3>;
                                 power = <250>;
                                 phys = <&phy1>;
                                 phy-names = "am335x-usb0";
                                 phy1: am335x-usb0 {
                                         compatible = "ti,am335x-usb2";
                                         #phy-cells = <0>;
                                         id= <0>;
                                 };
                         };

                         usb1@47401800 {
                                 reg = <0x47401800 0x800>;
                                 interrupts = <19>;
                                 interrupt-names = "mc";
                                 multipoint = <1>;
                                 num-eps = <16>;
                                 ram-bits = <12>;
                                 port-mode = <3>;
                                 power = <250>;
                                 phys = <&phy2>;
                                 phy-names = "am335x-usb1";
                                 phy2: am335x-usb1 {
                                         compatible = "ti,am335x-usb2";
                                         #phy-cells = <0>;
                                         id= <1>;
                                 };
                         };

                 };

-- 
-George

WARNING: multiple messages have this Message-ID (diff)
From: George Cherian <george.cherian@ti.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	<linux-usb@vger.kernel.org>, <balbi@ti.com>,
	<linux-kernel@vger.kernel.org>, <gregkh@linuxfoundation.org>,
	<linux-omap@vger.kernel.org>, <kishon@ti.com>
Subject: Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX
Date: Mon, 22 Jul 2013 11:15:41 +0530	[thread overview]
Message-ID: <51ECC705.2070904@ti.com> (raw)
In-Reply-To: <51EA06EB.4080709@ti.com>

On 7/20/2013 9:11 AM, George Cherian wrote:
> On 7/20/2013 12:12 AM, Sebastian Andrzej Siewior wrote:
>> On 07/19/2013 08:33 PM, Sergei Shtylyov wrote:
>>> Hello.
>> Hello,
>>
>>>> usb: usb@47400000 {
>>>>      compatible = "ti,am33xx-usb";
>>>>           usb0_phy: phy@47401300 {
>>>>          compatible = "ti,am335x-usb-phy";
>>>>      }
>>>>      usb0: usb@47401000 {
>>>>          musb0: usb@47401400 {
>>>>              compatible = "mg,musbmhdrc";
>>>>          }
>>>>      }
>>>>      usb1_phy: phy@47402300 {
>>>>          compatible = "ti,am335x-usb-phy";
>>>>      }
>>>>      usb1: usb@47402000 {
>>>>          musb1: usb@47402400 {
>>>>              compatible = "mg,musbmhdrc";
>>>>          }
>>>>      }
>>>> }

How about something like this ?

Here am making
     wrapper -> musb instance 0 -> phy0
     wrapper -> musb instance 1 -> phy1

                 musb: usb@47400000 {
                         compatible = "ti,musb-am33xx";
                         reg = <0x47400000 0x1000>;
                         ranges;
                         #address-cells = <1>;
                         #size-cells = <1>;
                         interrupts = <17>;
                         ti,hwmods = "usb_otg_hs";

                         usb0@47401000 {
                                 reg = <0x47401000 0x800>;
                                 interrupts = <18>;
                                 interrupt-names = "mc";
                                 multipoint = <1>;
                                 num-eps = <16>;
                                 ram-bits = <12>;
                                 port-mode = <3>;
                                 power = <250>;
                                 phys = <&phy1>;
                                 phy-names = "am335x-usb0";
                                 phy1: am335x-usb0 {
                                         compatible = "ti,am335x-usb2";
                                         #phy-cells = <0>;
                                         id= <0>;
                                 };
                         };

                         usb1@47401800 {
                                 reg = <0x47401800 0x800>;
                                 interrupts = <19>;
                                 interrupt-names = "mc";
                                 multipoint = <1>;
                                 num-eps = <16>;
                                 ram-bits = <12>;
                                 port-mode = <3>;
                                 power = <250>;
                                 phys = <&phy2>;
                                 phy-names = "am335x-usb1";
                                 phy2: am335x-usb1 {
                                         compatible = "ti,am335x-usb2";
                                         #phy-cells = <0>;
                                         id= <1>;
                                 };
                         };

                 };

-- 
-George


  reply	other threads:[~2013-07-22  5:45 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19 12:34 [PATCH v2 0/4] Add phy support for AM335X platform using Generic PHy framework George Cherian
2013-07-19 12:34 ` George Cherian
2013-07-19 12:34 ` [PATCH v2 1/4] usb: phy: phy-omap-control: Add API to power and wakeup George Cherian
2013-07-19 12:34   ` George Cherian
2013-07-19 13:20   ` Kishon Vijay Abraham I
2013-07-19 13:20     ` Kishon Vijay Abraham I
2013-07-29 14:25   ` Sebastian Andrzej Siewior
2013-07-30  4:53     ` George Cherian
2013-07-30  4:53       ` George Cherian
2013-07-30  7:35       ` Sebastian Andrzej Siewior
2013-07-19 12:34 ` [PATCH v2 2/4] phy: phy-amxxxx-usb: Add PHY driver for amxxxx platform George Cherian
2013-07-19 12:34   ` George Cherian
2013-07-19 13:32   ` Kishon Vijay Abraham I
2013-07-19 13:32     ` Kishon Vijay Abraham I
2013-07-29 15:17   ` Sebastian Andrzej Siewior
2013-07-30  5:19     ` George Cherian
2013-07-30  5:19       ` George Cherian
2013-07-30  8:53       ` Sebastian Andrzej Siewior
2013-07-30 14:24         ` George Cherian
2013-07-30 14:24           ` George Cherian
2013-07-30 14:33           ` Felipe Balbi
2013-07-30 14:33             ` Felipe Balbi
2013-07-30 14:39             ` Sebastian Andrzej Siewior
2013-07-19 12:34 ` [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX George Cherian
2013-07-19 12:34   ` George Cherian
2013-07-19 13:34   ` Kishon Vijay Abraham I
2013-07-19 13:34     ` Kishon Vijay Abraham I
2013-07-19 13:56   ` Sergei Shtylyov
2013-07-19 14:20     ` Sebastian Andrzej Siewior
2013-07-19 18:33       ` Sergei Shtylyov
2013-07-19 18:42         ` Sebastian Andrzej Siewior
2013-07-20  3:41           ` George Cherian
2013-07-20  3:41             ` George Cherian
2013-07-22  5:45             ` George Cherian [this message]
2013-07-22  5:45               ` George Cherian
2013-07-20  3:36         ` George Cherian
2013-07-20  3:36           ` George Cherian
2013-07-19 12:34 ` [PATCH v2 4/4] usb: musb: dsps: Remove the phy control from glue and add phy driver APIs George Cherian
2013-07-19 12:34   ` George Cherian
2013-07-19 13:44   ` Kishon Vijay Abraham I
2013-07-19 13:44     ` Kishon Vijay Abraham I
2013-07-19 13:17 ` [PATCH v2 0/4] Add phy support for AM335X platform using Generic PHy framework Kishon Vijay Abraham I
2013-07-19 13:17   ` Kishon Vijay Abraham I
2013-08-10 11:59 ` Ezequiel Garcia
2013-08-14 10:36   ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51ECC705.2070904@ti.com \
    --to=george.cherian@ti.com \
    --cc=balbi@ti.com \
    --cc=bigeasy@linutronix.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.