Re: [PATCH v2 00/11] virtio: console: fixes for port unplug

[Jason Wang <jasowang@redhat.com>]

On 07/19/2013 07:21 PM, Amit Shah wrote:
> Hello,
>
> This series fixes a few bugs and races with port unplug and the
> various file operations: read(), write(), close() and poll().
>
> There still might be more races lurking, but testing this series looks
> good to at least solve the easily-triggerable ones.  I've run the
> virtio-serial testsuite and a few open/close/unplug tests, and haven't
> seen any badness.
>
> I've marked these patches for stable@ as well.  I went over the list
> twice to check if really each one should go to stable, and to me it
> looks like all are stable candidates.
>
> v2
>  * add patch 11: Jason found a use-after-free in port unplug
>  * patch 7 introduced a regression where the wake_up_interruptible was
>    done before guest_connected and host_connected were set to false
>
> Please review and apply,

For the series.

Reviewed-by: Jason Wang <jasowang@redhat.com>

Thanks
> Amit Shah (11):
>   virtio: console: fix race with port unplug and open/close
>   virtio: console: fix race in port_fops_open() and port unplug
>   virtio: console: clean up port data immediately at time of unplug
>   virtio: console: return -ENODEV on all read operations after unplug
>   virtio: console: update private_data in struct file only on successful
>     open
>   virtio: console: fix race in port_fops_poll() and port unplug
>   virtio: console: fix raising SIGIO after port unplug
>   virtio: console: add locks around buffer removal in port unplug path
>   virtio: console: add locking in port unplug path
>   virtio: console: fix locking around send_sigio_to_port()
>   virtio: console: prevent use-after-free of port name in port unplug
>
>  drivers/char/virtio_console.c | 70 +++++++++++++++++++++++++++----------------
>  1 file changed, 45 insertions(+), 25 deletions(-)
>