diff for duplicates of <51ECF184.9030305@cn.fujitsu.com> diff --git a/a/1.txt b/N1/1.txt index 9cda780..b41bd89 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -7,7 +7,7 @@ On mon, 22 Jul 2013 09:55:15 +0300, Dan Carpenter wrote: > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -From the viewpoint of the readability, it is better to free raid_map and bbio +>From the viewpoint of the readability, it is better to free raid_map and bbio in the caller, I think. But it is up to you. Reviewed-by: Miao Xie <miaox@cn.fujitsu.com> @@ -43,7 +43,7 @@ Reviewed-by: Miao Xie <miaox@cn.fujitsu.com> > bio_list_add(&rbio->bio_list, bio); > @@ -2052,6 +2048,8 @@ int raid56_parity_recover(struct btrfs_root *root, struct bio *bio, > rbio->faila = find_logical_bio_stripe(rbio, bio); -> if (rbio->faila = -1) { +> if (rbio->faila == -1) { > BUG(); > + kfree(raid_map); > + kfree(bbio); diff --git a/a/content_digest b/N1/content_digest index 9977dc9..30524b4 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020130722065515.GB14617@longonot.mountain\0" "From\0Miao Xie <miaox@cn.fujitsu.com>\0" "Subject\0Re: [patch] btrfs/raid56: fix and cleanup some error paths\0" - "Date\0Mon, 22 Jul 2013 08:47:00 +0000\0" + "Date\0Mon, 22 Jul 2013 16:47:00 +0800\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Cc\0Chris Mason <chris.mason@fusionio.com>" linux-btrfs@vger.kernel.org @@ -17,7 +17,7 @@ "> \n" "> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n" "\n" - "From the viewpoint of the readability, it is better to free raid_map and bbio\n" + ">From the viewpoint of the readability, it is better to free raid_map and bbio\n" "in the caller, I think. But it is up to you.\n" "\n" "Reviewed-by: Miao Xie <miaox@cn.fujitsu.com>\n" @@ -53,7 +53,7 @@ "> \tbio_list_add(&rbio->bio_list, bio);\n" "> @@ -2052,6 +2048,8 @@ int raid56_parity_recover(struct btrfs_root *root, struct bio *bio,\n" "> \trbio->faila = find_logical_bio_stripe(rbio, bio);\n" - "> \tif (rbio->faila = -1) {\n" + "> \tif (rbio->faila == -1) {\n" "> \t\tBUG();\n" "> +\t\tkfree(raid_map);\n" "> +\t\tkfree(bbio);\n" @@ -66,4 +66,4 @@ "> More majordomo info at http://vger.kernel.org/majordomo-info.html\n" > -bdf22f142cfbfdc1d681c647cad568fc243c6be3fea966c6ffb6f1d898c372f1 +8440e527d985ab46863563385985a499e298b40638af42387fbb8eb45b609851
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.