From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] exec: Fix bounce buffer allocation in address_space_map()
Date: Mon, 22 Jul 2013 15:06:33 +0200 [thread overview]
Message-ID: <51ED2E59.3080204@redhat.com> (raw)
In-Reply-To: <1374497038-22136-2-git-send-email-kwolf@redhat.com>
Il 22/07/2013 14:43, Kevin Wolf ha scritto:
> - bounce.buffer = qemu_memalign(TARGET_PAGE_SIZE, TARGET_PAGE_SIZE);
> + /* Avoid unbounded allocations */
> + l = TARGET_PAGE_SIZE;
This should be l = MIN(l, TARGET_PAGE_SIZE). Otherwise the patch is okay.
Paolo
> + bounce.buffer = qemu_memalign(TARGET_PAGE_SIZE, l);
next prev parent reply other threads:[~2013-07-22 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 12:43 [Qemu-devel] [PATCH 0/2] exec: Fix bounce buffer allocation in address_space_map() Kevin Wolf
2013-07-22 12:43 ` [Qemu-devel] [PATCH 1/2] " Kevin Wolf
2013-07-22 13:06 ` Paolo Bonzini [this message]
2013-07-22 13:55 ` Kevin Wolf
2013-07-22 12:43 ` [Qemu-devel] [PATCH 2/2] ide-test: Check what happens with bus mastering disabled Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ED2E59.3080204@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.