Re: [Qemu-devel] [PATCH qom-cpu v2 01/42] cpu: Introduce vaddr type

["Andreas Färber" <afaerber@suse.de>]

Am 15.07.2013 16:46, schrieb Peter Maydell:
> On 7 July 2013 19:25, Andreas Färber <afaerber@suse.de> wrote:
>> vaddr is to target_ulong what uintmax_t is to unsigned int.
>>
>> Its purpose is to allow turning per-target functions with target_ulong
>> arguments into CPUClass hooks.
>>
>> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>>  include/qom/cpu.h | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/include/qom/cpu.h b/include/qom/cpu.h
>> index 147c256..4fd12a0 100644
>> --- a/include/qom/cpu.h
>> +++ b/include/qom/cpu.h
>> @@ -29,6 +29,14 @@
>>
>>  typedef int (*WriteCoreDumpFunction)(void *buf, size_t size, void *opaque);
>>
>> +typedef uint64_t vaddr;
>> +#define VADDR_PRId PRId64
>> +#define VADDR_PRIu PRIu64
>> +#define VADDR_PRIo PRIo64
>> +#define VADDR_PRIx PRIx64
>> +#define VADDR_PRIX PRIX64
>> +#define VADDR_MAX UINT64_MAX
>> +
> 
> This looks OK, but I think it could use a brief comment above
> the typedef explaining its purpose, and an update to HACKING
> to say when to use vaddr and when target_ulong.

I've added a gtk-doc comment. Not sure about HACKING, that can still be
done as fully reviewed follow-up.

(Note that v3 was identical to the above.)

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg