From: Eric Blake <eblake@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, phrdina@redhat.com, famz@redhat.com,
armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com,
stefanha@redhat.com, pbonzini@redhat.com, dietmar@proxmox.com
Subject: Re: [Qemu-devel] [PATCH V6 1/8] snapshot: new function bdrv_snapshot_find_by_id_and_name()
Date: Mon, 22 Jul 2013 12:55:41 -0600 [thread overview]
Message-ID: <51ED802D.3020207@redhat.com> (raw)
In-Reply-To: <1374327070-11400-2-git-send-email-xiawenc@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
On 07/20/2013 07:31 AM, Wenchao Xia wrote:
> To make it clear about id and name in searching, add this API
> to distinguish them. Caller can choose to search by id or name,
> *errp will be set only for exception.
>
> Some code are modified based on Pavel's patch.
>
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
> block/snapshot.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++
> include/block/snapshot.h | 6 ++++
> 2 files changed, 79 insertions(+), 0 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-07-22 18:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-20 13:31 [Qemu-devel] [PATCH V6 0/8] add internal snapshot support at block device level Wenchao Xia
2013-07-20 13:31 ` [Qemu-devel] [PATCH V6 1/8] snapshot: new function bdrv_snapshot_find_by_id_and_name() Wenchao Xia
2013-07-22 18:55 ` Eric Blake [this message]
2013-07-20 13:31 ` [Qemu-devel] [PATCH V6 2/8] snapshot: distinguish id and name in snapshot delete Wenchao Xia
2013-07-20 13:31 ` [Qemu-devel] [PATCH V6 3/8] qmp: add internal snapshot support in qmp_transaction Wenchao Xia
2013-07-20 13:31 ` [Qemu-devel] [PATCH V6 4/8] qmp: add interface blockdev-snapshot-internal-sync Wenchao Xia
2013-07-20 13:31 ` [Qemu-devel] [PATCH V6 5/8] qmp: add interface blockdev-snapshot-delete-internal-sync Wenchao Xia
2013-07-20 13:31 ` [Qemu-devel] [PATCH V6 6/8] hmp: add interface hmp_snapshot_blkdev_internal Wenchao Xia
2013-07-20 13:31 ` [Qemu-devel] [PATCH V6 7/8] hmp: add interface hmp_snapshot_delete_blkdev_internal Wenchao Xia
2013-07-20 13:31 ` [Qemu-devel] [PATCH V6 8/8] qemu-iotests: add 056 internal snapshot for block device test case Wenchao Xia
2013-07-30 2:59 ` [Qemu-devel] [PATCH V6 0/8] add internal snapshot support at block device level Wenchao Xia
2013-08-07 3:01 ` Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ED802D.3020207@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=dietmar@proxmox.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=phrdina@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.