From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49341)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V1NZw-0000CB-EC
	for qemu-devel@nongnu.org; Mon, 22 Jul 2013 17:23:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V1NZv-000639-9a
	for qemu-devel@nongnu.org; Mon, 22 Jul 2013 17:23:36 -0400
Received: from cantor2.suse.de ([195.135.220.15]:42435 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V1NZv-000635-1f
	for qemu-devel@nongnu.org; Mon, 22 Jul 2013 17:23:35 -0400
Message-ID: <51EDA2D1.5080603@suse.de>
Date: Mon, 22 Jul 2013 23:23:29 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <51ED9E3F.3080504@hds.com>
In-Reply-To: <51ED9E3F.3080504@hds.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Convert stderr message calling
 error_get_pretty() to error_report() to prepend timestamp
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Seiji Aguchi <seiji.aguchi@hds.com>
Cc: lersek@redhat.com, qemu-devel@nongnu.org, tomoki.sekiyama@hds.com, lcapitulino@redhat.com

Am 22.07.2013 23:03, schrieb Seiji Aguchi:
> Convert stderr messages calling error_get_pretty()
> to error_report().
>=20
> Timestamp is prepended by -msg timstamp option with it.
>=20
> This is suggested by Luiz Capitulino.
>=20
> http://marc.info/?l=3Dqemu-devel&m=3D137331442628866&w=3D2
>=20
> Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com>
> ---
>  arch_init.c                 |    4 ++--
>  hw/char/serial.c            |    5 +++--
>  hw/i386/pc.c                |    6 +++---
>  qemu-char.c                 |    2 +-
>  target-i386/cpu.c           |    2 +-
>  target-ppc/translate_init.c |    3 ++-
>  vl.c                        |    9 +++++----
>  7 files changed, 17 insertions(+), 14 deletions(-)

How is this related to error_get_pretty()?

And does error_report() expect a trailing \n or not? I would assume no,
but spotted some in this patch.

If you feel strongly about having error_report() consistently, please
let me know if there are any in my qom-next queue that need fixing.
https://github.com/afaerber/qemu-cpu/commits/qom-next

Thanks,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg