On 07/22/2013 03:07 PM, Laszlo Ersek wrote: > Signed-off-by: Laszlo Ersek > --- > tests/Makefile | 6 +- > qapi-schema-test.json | 15 +++ > tests/test-opts-visitor.c | 275 +++++++++++++++++++++++++++++++++++++++++++++ > .gitignore | 1 + > 4 files changed, 296 insertions(+), 1 deletions(-) > create mode 100644 tests/test-opts-visitor.c > + add_test("/visitor/opts/i64/val1/errno", &expect_fail, > + "i64=0x8000000000000000"); > + add_test("/visitor/opts/i64/val1/empty", &expect_fail, "i64="); > + add_test("/visitor/opts/i64/val1/trailing", &expect_fail, "i64=5z"); > + add_test("/visitor/opts/i64/nonlist", &expect_fail, "i64x=5-6"); > + add_test("/visitor/opts/i64/val2/errno", &expect_fail, > + "i64=0x7fffffffffffffff-0x8000000000000000"); > + add_test("/visitor/opts/i64/val2/empty", &expect_fail, "i64=5-"); > + add_test("/visitor/opts/i64/val2/trailing", &expect_fail, "i64=5-6z"); > + add_test("/visitor/opts/i64/range/empty", &expect_fail, "i64=6-5"); > + add_test("/visitor/opts/i64/range/minval", &expect_i64_min, > + "i64=-0x8000000000000000--0x8000000000000000"); > + add_test("/visitor/opts/i64/range/maxval", &expect_i64_max, > + "i64=0x7fffffffffffffff-0x7fffffffffffffff"); Pretty thorough, although I thought of a couple other ideas to test: i64=5z-6 should fail; i64=5-6-7 should fail -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org