Re: [PATCH] Cygwin has trustable filemode

[Mark Levedahl <mlevedahl@gmail.com>]

On 07/22/2013 01:02 AM, Junio C Hamano wrote:
>> b) The Cygwin project has always shipped git binaries built without
>> NO_TRUSTABLE_FILEMODE
> That is a fair point.  So let's do this instead.
>
> -- >8 --
> From: Mark Levedahl <mlevedahl@gmail.com>
> Subject: [PATCH] cygwin: stop forcing core.filemode=false
>
> We force core.filemode=false since c869753e (Force core.filemode to
> false on Cygwin., 2006-12-30), even when the repository is on a
> filesystem on which Cygwin can give us trustable filemodes, because
> many native Windows applications the users use to edit files in the
> working tree tend to (re)create files with executable bit randomly
> set or reset.  However, binary distribution of Git that is supplied
> by the downstream project to its users has been built without this
> consideration.
>
> Drop NO_TRUSTABLE_FILEMODE from our default configuration so that
> hand-compiled Git out of box will match theirs.
>
> Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>   config.mak.uname | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/config.mak.uname b/config.mak.uname
> index 7ac541e..779d06a 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -163,7 +163,6 @@ ifeq ($(uname_O),Cygwin)
>   	NO_THREAD_SAFE_PREAD = YesPlease
>   	NEEDS_LIBICONV = YesPlease
>   	NO_FAST_WORKING_DIRECTORY = UnfortunatelyYes
> -	NO_TRUSTABLE_FILEMODE = UnfortunatelyYes
>   	NO_ST_BLOCKS_IN_STRUCT_STAT = YesPlease
>   	# There are conflicting reports about this.
>   	# On some boxes NO_MMAP is needed, and not so elsewhere.
ok by me.

Mark