From: Saul Wold <sgw@linux.intel.com>
To: Qi.Chen@windriver.com
Cc: qingtao.cao@windriver.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/3] rpm: remove the obsolete rpm-postinsts.bb
Date: Mon, 22 Jul 2013 16:49:33 -0700 [thread overview]
Message-ID: <51EDC50D.3050503@linux.intel.com> (raw)
In-Reply-To: <9d5689b2a901728c1695d0889e27d2507c5c61a4.1374226651.git.Qi.Chen@windriver.com>
On 07/19/2013 02:39 AM, Qi.Chen@windriver.com wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> Now that the postinsts of rpm, deb and ipk are all handled in the one
> central place, run-postinsts.bb, the rpm-postinsts.bb recipe is actually
> obsolete now. Remove this recipe to avoid confusion.
>
There still seems to be references to rpm-postinsts in the rootfs_rpm,
package_rpm and image.bb, while these seem unused, we should clean these
all up at the same time.
Sau!
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> meta/recipes-devtools/rpm/rpm-postinsts.bb | 54 ----------------------------
> 1 file changed, 54 deletions(-)
> delete mode 100644 meta/recipes-devtools/rpm/rpm-postinsts.bb
>
> diff --git a/meta/recipes-devtools/rpm/rpm-postinsts.bb b/meta/recipes-devtools/rpm/rpm-postinsts.bb
> deleted file mode 100644
> index ba58cd4..0000000
> --- a/meta/recipes-devtools/rpm/rpm-postinsts.bb
> +++ /dev/null
> @@ -1,54 +0,0 @@
> -DESCRIPTION = "RPM postinstall script"
> -SECTION = "core"
> -LICENSE = "LGPLv2.1"
> -LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/LGPL-2.1;md5=1a6d268fd218675ffea8be556788b780"
> -
> -inherit allarch
> -#
> -# Allow distributions to alter when [postponed] package install scripts are run
> -#
> -POSTINSTALL_INITPOSITION ?= "98"
> -
> -do_fetch() {
> - :
> -}
> -
> -do_configure() {
> - :
> -}
> -
> -do_compile() {
> - :
> -}
> -
> -do_install() {
> - :
> -}
> -
> -pkg_postinst_${PN} () {
> -if [ "x$D" != "x" ] && [ -f $D/var/lib/rpm/Packages ]; then
> - install -d $D/${sysconfdir}/rcS.d
> - cat > $D${sysconfdir}/rcS.d/S${POSTINSTALL_INITPOSITION}run-postinsts << "EOF"
> -#!/bin/sh
> -[ -e ${sysconfdir}/default/postinst ] && . ${sysconfdir}/default/postinst
> -[ -d ${sysconfdir}/rpm-postinsts ] && for i in `ls ${sysconfdir}/rpm-postinsts/`; do
> - i=${sysconfdir}/rpm-postinsts/$i
> - echo "Running postinst $i..."
> - if [ -x $i ]; then
> - if [ "$POSTINST_LOGGING" = "1" ]; then
> - $i >>$LOGFILE 2>&1
> - else
> - $i
> - fi
> - rm $i
> - else
> - echo "ERROR: postinst $i failed."
> - fi
> -done
> -rm -f ${sysconfdir}/rcS.d/S${POSTINSTALL_INITPOSITION}run-postinsts 2>/dev/null
> -EOF
> - chmod 0755 $D${sysconfdir}/rcS.d/S${POSTINSTALL_INITPOSITION}run-postinsts
> -fi
> -}
> -
> -ALLOW_EMPTY_${PN} = "1"
>
next prev parent reply other threads:[~2013-07-22 23:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 9:39 [PATCH 0/3] run-postinsts fixes Qi.Chen
2013-07-19 9:39 ` [PATCH 1/3] rpm: remove the obsolete rpm-postinsts.bb Qi.Chen
2013-07-22 23:49 ` Saul Wold [this message]
2013-07-23 2:04 ` ChenQi
2013-07-19 9:39 ` [PATCH 2/3] run-postinsts: fix comment Qi.Chen
2013-07-19 9:39 ` [PATCH 3/3] run-postinsts: add more logging to the log file to make things clearer Qi.Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EDC50D.3050503@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=Qi.Chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=qingtao.cao@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.