Re: [PATCH 1/1] x86, acpi: Fix wrong checking condition in acpi_register_lapic().

[Tang Chen <tangchen@cn.fujitsu.com>]

On 07/23/2013 03:39 PM, Ingo Molnar wrote:
>
> * Tang Chen<tangchen@cn.fujitsu.com>  wrote:
>
>> We wanted to check if the acpi id is out of range. It should be:
>> 	if (id>= (MAX_LOCAL_APIC)).
>
> Does this have any practical impact, or can it wait until v3.12?

I haven't tested out any impact now, just found it when reading the code.
We can wait until v3.12.

>
>> Signed-off-by: Tang Chen<tangchen@cn.fujitsu.com>
>> ---
>>   arch/x86/kernel/acpi/boot.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
>> index d81a972..2a15ae7 100644
>> --- a/arch/x86/kernel/acpi/boot.c
>> +++ b/arch/x86/kernel/acpi/boot.c
>> @@ -199,7 +199,7 @@ static void __cpuinit acpi_register_lapic(int id, u8 enabled)
>>   {
>>   	unsigned int ver = 0;
>>
>> -	if (id>= (MAX_LOCAL_APIC-1)) {
>> +	if (id>= (MAX_LOCAL_APIC)) {
>
> The parentheses are now superfluous.

Oh, yes. I'll send a new version without the parentheses.

Thanks.