From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1Yvr-0005xu-R2 for qemu-devel@nongnu.org; Tue, 23 Jul 2013 05:31:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1Yvq-0008Bf-Fb for qemu-devel@nongnu.org; Tue, 23 Jul 2013 05:30:59 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60767 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1Yvq-0008BV-7S for qemu-devel@nongnu.org; Tue, 23 Jul 2013 05:30:58 -0400 Message-ID: <51EE4D4B.3070808@suse.de> Date: Tue, 23 Jul 2013 11:30:51 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <25C84044-9F40-4076-BDAB-03363073B671@cs2c.com.cn> <20130723085146.GA2695@stefanha-thinkpad.redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/3] dataplane: virtio-blk live migration with x-data-plane=on List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: yinyin Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Hi, Am 23.07.2013 11:19, schrieb yinyin: > Hi, Stefan: > during the migration, the source, not the destination, will start data= plane again.... > I think the process of migration with dataplane as follows: > 1. migration begin to start > 2. the migration source stop the dataplane > 3. do migration ... > 4. migration completed, the destination start the dataplane. I can't speak for the dataplane, but in general the source guest is expected to continue working during live migration (that's the "live" part) until it has been fully transferred to the destination. HTH, Andreas > when migration start, the source dataplane should already stopped, and = not start again, if there is no cancel or abort. > But the trace show that, in step 3 above, the source dataplane will be = start by virtio_blk_handle_output. I'm afraid of some inconsistent will h= appen there.Is it right? >=20 > There is no crash found, I just use this trace to understand the flow o= f dataplane migration.=20 >=20 > Yin Yin > yin.yin@cs2c.com.cn >=20 > =20 > =E5=9C=A8 2013-7-23=EF=BC=8C=E4=B8=8B=E5=8D=884:51=EF=BC=8CStefan Hajno= czi =E5=86=99=E9=81=93=EF=BC=9A >=20 >> On Fri, Jul 19, 2013 at 01:33:12PM +0800, yinyin wrote: >>> I use systemtap to test this patch,the migration will success. But I= found the dataplane will start again after migration start. the virtio_b= lk_handle_output will start dataplane. >> >> Hi Yin Yin, >> Thank you for testing the patch. It is not clear to me whether you >> encountered a problem or not. >> >> It is expected that the destination will start the dataplane thread. >> Was there a crash or some reason why you posted these traces? >> >> Stefan >> >=20 >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg