All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sourav Poddar <sourav.poddar@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv2 3/8] spi: add TI QSPI driver
Date: Tue, 23 Jul 2013 15:03:41 +0530	[thread overview]
Message-ID: <51EE4DF5.8000700@ti.com> (raw)
In-Reply-To: <20130723092345.EB273380ADF@gemini.denx.de>

On Tuesday 23 July 2013 02:53 PM, Wolfgang Denk wrote:
> Dear Sourav Poddar,
>
> In message<1374569979-28660-4-git-send-email-sourav.poddar@ti.com>  you wrote:
>> From: Matt Porter<matt.porter@linaro.org>
>>
>> Adds a SPI master driver for the TI QSPI peripheral.
>>
>> Signed-off-by: Matt Porter<matt.porter@linaro.org>
>> Signed-off-by: Sourav Poddar<sourav.poddar@ti.com>
>> ---
>>   drivers/spi/Makefile  |    1 +
>>   drivers/spi/ti_qspi.c |  262 +++++++++++++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 263 insertions(+), 0 deletions(-)
>>   create mode 100644 drivers/spi/ti_qspi.c
> when submitting a new version of a patch or patch series, it is
> mandatory to supply a chancgelog that desribes what you changed
> compareds to previous versions of the patch.  This is necessary so
> that reviewers can see which of their hints were taken into account,
> etc.
>
> This is missing in all you patches of this series.
Ok. will add in the next version.
> Also, please run all your patches through checkpatch _before_
> submitting.  For this patch, I get some "line over 80 characters"
> wanings that need to be fixed.  This should not happen.  Please be
> more careful next time.
>
Hmm...will check and remove.
> Best regards,
>
> Wolfgang Denk
>

  reply	other threads:[~2013-07-23  9:33 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23  8:59 [U-Boot] [PATCHv2 0/8] qspi controller: Normal, quad and memory mapped read support Sourav Poddar
2013-07-23  8:59 ` [U-Boot] [PATCHv2 1/8] omap5: add qspi support Sourav Poddar
2013-07-23  8:59 ` [U-Boot] [PATCHv2 2/8] armv7: hw_data: change clock divider setting Sourav Poddar
2013-07-23  8:59 ` [U-Boot] [PATCHv2 3/8] spi: add TI QSPI driver Sourav Poddar
2013-07-23  9:23   ` Wolfgang Denk
2013-07-23  9:33     ` Sourav Poddar [this message]
2013-07-23  8:59 ` [U-Boot] [PATCHv2 4/8] dra7xx_evm: add SPL API, QSPI, and serial flash support Sourav Poddar
2013-07-23  8:59 ` [U-Boot] [PATCHv2 5/8] drivers: mtd: spi: Modify read/write command for sfl256s flash Sourav Poddar
2013-07-23 14:23   ` Sourav Poddar
2013-07-23 14:30     ` Felipe Balbi
2013-07-23 14:53       ` Sourav Poddar
2013-07-31  6:53     ` Sourav Poddar
2013-08-07  5:57       ` Sourav Poddar
2013-08-07 11:51         ` Jagan Teki
2013-08-07 12:04           ` Sourav Poddar
2013-08-07 15:05             ` Jagan Teki
2013-08-07 15:16               ` Sourav Poddar
2013-10-07 12:21                 ` Jagan Teki
2013-10-07 12:28                   ` Sourav Poddar
2013-10-07 12:29                     ` Jagan Teki
2013-10-07 12:30                       ` Sourav Poddar
2013-07-23  8:59 ` [U-Boot] [PATCHv2 6/8] drivers: mtd: qspi: Add quad read support Sourav Poddar
2013-07-23  9:28   ` Wolfgang Denk
2013-07-23  8:59 ` [U-Boot] [PATCHv2 7/8] driver: spi: Add memory mapped " Sourav Poddar
2013-07-23  9:29   ` Wolfgang Denk
2013-07-23  9:34     ` Sourav Poddar
2013-07-23  8:59 ` [U-Boot] [PATCHv2 8/8] README: qspi usecase and testing documentation Sourav Poddar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51EE4DF5.8000700@ti.com \
    --to=sourav.poddar@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.