From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: linux-can@vger.kernel.org, festevam@gmail.com
Subject: Re: [PATCH v2 1/2] flexcan: Use devm_ioremap_resource()
Date: Tue, 23 Jul 2013 12:08:20 +0200 [thread overview]
Message-ID: <51EE5614.10008@pengutronix.de> (raw)
In-Reply-To: <1374507700-21575-1-git-send-email-fabio.estevam@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On 07/22/2013 05:41 PM, Fabio Estevam wrote:
> Using devm_ioremap_resource() can make the code simpler and smaller.
>
> Also, place alloc_candev() after of_match_device() to make error handling
> easier.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Looks good, I've added a "can: " prefix to the subject while applying
the patch to linux-can-next.
thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
prev parent reply other threads:[~2013-07-23 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 15:41 [PATCH v2 1/2] flexcan: Use devm_ioremap_resource() Fabio Estevam
2013-07-22 15:41 ` [PATCH v2 2/2] flexcan: Check the return value from clk_prepare_enable() Fabio Estevam
2013-07-23 10:08 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EE5614.10008@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.