From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1ZjB-0004h0-UO for qemu-devel@nongnu.org; Tue, 23 Jul 2013 06:21:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1ZjA-0000qv-Mw for qemu-devel@nongnu.org; Tue, 23 Jul 2013 06:21:57 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34319 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1ZjA-0000qh-Hu for qemu-devel@nongnu.org; Tue, 23 Jul 2013 06:21:56 -0400 Message-ID: <51EE593F.4090101@suse.de> Date: Tue, 23 Jul 2013 12:21:51 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1374415744-6675-1-git-send-email-afaerber@suse.de> <1374415744-6675-5-git-send-email-afaerber@suse.de> <20130721202607.GA15187@redhat.com> <87y58y49tx.fsf@codemonkey.ws> <51ED9E71.3060809@suse.de> <20130723070755.GB11106@redhat.com> <51EE4895.4010207@suse.de> <20130723095954.GA23217@redhat.com> In-Reply-To: <20130723095954.GA23217@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Gerd Hoffmann , qemu-devel@nongnu.org, Anthony Liguori , Juan Quintela Am 23.07.2013 11:59, schrieb Michael S. Tsirkin: > On Tue, Jul 23, 2013 at 11:10:45AM +0200, Andreas F=E4rber wrote: >> Am 23.07.2013 09:07, schrieb Michael S. Tsirkin: >>> On Mon, Jul 22, 2013 at 11:04:49PM +0200, Andreas F=E4rber wrote: >>>> For VMState I believe the real follow-up fix would be mst defining a >>>> central macro VMSTATE_PCI_DEVICE_AER_LOG() operating on PCIDevice. >>>> Why is that separate from VMSTATE_PCI_DEVICE() or VMSTATE_PCIE_DEVIC= E() >>>> in the first place? >=20 > I think the answer is that most pcie devices > don't implement AER. AFAIK PCI devices can't > support AER at all. Okay, so if it's just PCIe, then XHCI is the oddball preventing moving it into VMSTATE_PCIE_DEVICE(). XHCI has VMSTATE_MSIX() in its place, also operating on PCIDevice. Is there a way to detect use of AER or MSIX to place those into subsections of VMSTATE_PCIE_DEVICE()? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg