From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1alm-0003ko-7x for qemu-devel@nongnu.org; Tue, 23 Jul 2013 07:28:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1all-0006pr-8N for qemu-devel@nongnu.org; Tue, 23 Jul 2013 07:28:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1all-0006pS-0f for qemu-devel@nongnu.org; Tue, 23 Jul 2013 07:28:41 -0400 Message-ID: <51EE68DE.7080405@redhat.com> Date: Tue, 23 Jul 2013 13:28:30 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <518C8B16.4060108@suse.de> <51EE4CE1.7060402@tiscali.it> In-Reply-To: <51EE4CE1.7060402@tiscali.it> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH] vga: Start supporting resolution not multiple of 16 correctly. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fantonifabio@tiscali.it Cc: Peter Maydell , Anthony Liguori , xen-devel@lists.xensource.com, Stefano Stabellini , qemu-devel , Alon Levy , Frediano Ziglio , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Hi, > Tested-by: Fabio Fantoni > > I tested it for a long time with spice on xen (because qxl will be fully > working only after adding SSE support on hvm domUs). It works, I think > it is good to add this and the respective vgabios patch on upstream. >> case VBE_DISPI_INDEX_XRES: >> - if ((val <= VBE_DISPI_MAX_XRES) && ((val & 7) == 0)) { >> + if ((val <= VBE_DISPI_MAX_XRES) && ((val & 1) == 0)) { >> s->vbe_regs[s->vbe_index] = val; >> } >> break; It's not that simple. With 32bit depths common today it will work fine, but for lower depths (especially those lower than 8bit) this will give you broken scanline alignment. cheers, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [RFC PATCH] vga: Start supporting resolution not multiple of 16 correctly. Date: Tue, 23 Jul 2013 13:28:30 +0200 Message-ID: <51EE68DE.7080405@redhat.com> References: <518C8B16.4060108@suse.de> <51EE4CE1.7060402@tiscali.it> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51EE4CE1.7060402@tiscali.it> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: fantonifabio@tiscali.it Cc: Peter Maydell , Anthony Liguori , xen-devel@lists.xensource.com, Stefano Stabellini , qemu-devel , Alon Levy , Frediano Ziglio , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= List-Id: xen-devel@lists.xenproject.org Hi, > Tested-by: Fabio Fantoni > > I tested it for a long time with spice on xen (because qxl will be fully > working only after adding SSE support on hvm domUs). It works, I think > it is good to add this and the respective vgabios patch on upstream. >> case VBE_DISPI_INDEX_XRES: >> - if ((val <= VBE_DISPI_MAX_XRES) && ((val & 7) == 0)) { >> + if ((val <= VBE_DISPI_MAX_XRES) && ((val & 1) == 0)) { >> s->vbe_regs[s->vbe_index] = val; >> } >> break; It's not that simple. With 32bit depths common today it will work fine, but for lower depths (especially those lower than 8bit) this will give you broken scanline alignment. cheers, Gerd