Re: [PATCH V4] gpio: palmas: add dt support

[Stephen Warren <swarren@nvidia.com>]

On 07/23/2013 12:36 AM, Laxman Dewangan wrote:
> Add of_device_id table for Palma GPIO to be enable the
> driver from DT file.
> 
> The driver can be registered from DT file as:
> 	palmas: tps65913@58 {
> 		:::::::::::
> 		palmas_gpio: palmas_gpio {
> 			compatible = "ti,palmas-gpio";
> 			gpio-controller;
> 			#gpio-cells = <2>;
> 		};
> 	};

The binding at least,
Acked-by: Stephen Warren <swarren@nvidia.com>

> diff --git a/drivers/gpio/gpio-palmas.c b/drivers/gpio/gpio-palmas.c

>  #ifdef CONFIG_OF_GPIO
> -	palmas_gpio->gpio_chip.of_node = palmas->dev->of_node;
> +	palmas_gpio->gpio_chip.of_node = pdev->dev.of_node;
>  #endif

That still scares me slightly, in case someone is already using this
driver and this changes how it works, and it breaks something, but I
don't think anyone is, so this should be OK too.