All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH 2/4] ASOC: tegra: fix matching of AC97 components
Date: Tue, 23 Jul 2013 09:49:59 -0700	[thread overview]
Message-ID: <51EEB437.5030805@wwwdotorg.org> (raw)
In-Reply-To: <1374442132-24040-3-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>

On 07/21/2013 02:28 PM, Lucas Stach wrote:
> Matching works completely based on the cpu of_node.

> diff --git a/sound/soc/tegra/tegra_wm9712.c b/sound/soc/tegra/tegra_wm9712.c

>  static struct snd_soc_dai_link tegra_wm9712_dai = {
>  	.name = "AC97 HiFi",
>  	.stream_name = "AC97 HiFi",
> -	.cpu_dai_name = "tegra20-ac97",
>  	.codec_dai_name = "wm9712-hifi",
>  	.codec_name = "wm9712-codec",

Shouldn't codec_of_node be used in preference to codec_name too?

  parent reply	other threads:[~2013-07-23 16:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-21 21:28 [PATCH 0/4] Colibri T20 fixes for 3.11 Lucas Stach
     [not found] ` <1374442132-24040-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2013-07-21 21:28   ` [PATCH 1/4] ASOC: tegra: move AC97 clock defines to the controller node Lucas Stach
2013-07-21 23:36     ` Mark Brown
     [not found]       ` <20130721233651.GZ9858-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-07-22  7:08         ` Lucas Stach
2013-07-22  9:46           ` Mark Brown
     [not found]             ` <20130722094627.GK9858-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-07-22 16:26               ` Lucas Stach
2013-07-24  9:44                 ` Mark Brown
     [not found]     ` <1374442132-24040-2-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2013-07-23 16:47       ` Stephen Warren
     [not found]         ` <51EEB3A6.1060507-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-07-23 20:37           ` Lucas Stach
2013-07-21 21:28   ` [PATCH 2/4] ASOC: tegra: fix matching of AC97 components Lucas Stach
     [not found]     ` <1374442132-24040-3-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2013-07-23 16:49       ` Stephen Warren [this message]
2013-07-21 21:28   ` [PATCH 3/4] ARM: tegra: enable ULPI phy on Colibri T20 Lucas Stach
     [not found]     ` <1374442132-24040-4-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2013-07-23 16:53       ` Stephen Warren
2013-07-21 21:28   ` [PATCH 4/4] ARM: tegra: correct Colibri T20 regulator settings Lucas Stach
     [not found]     ` <1374442132-24040-5-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2013-07-23 18:07       ` Stephen Warren
     [not found]         ` <51EEC669.9050703-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-07-23 20:35           ` Lucas Stach
2013-07-23 20:53             ` Stephen Warren
2013-07-28 22:06       ` Stefan Agner
2013-08-15 11:05       ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51EEB437.5030805@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.