From: Jason Wang <jasowang@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: davem@davemloft.net, mst@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Basil Gor <basil.gor@gmail.com>
Subject: Re: [PATCH net-next] tuntap: hardware vlan tx support
Date: Wed, 24 Jul 2013 12:41:36 +0800 [thread overview]
Message-ID: <51EF5B00.7040109@redhat.com> (raw)
In-Reply-To: <20130723081727.69766d27@nehalam.linuxnetplumber.net>
On 07/23/2013 11:17 PM, Stephen Hemminger wrote:
> On Tue, 23 Jul 2013 15:15:48 +0800
> Jason Wang <jasowang@redhat.com> wrote:
>
>> Inspired by commit f09e2249c4f5c7c13261ec73f5a7807076af0c8e (macvtap: restore
>> vlan header on user read). This patch adds hardware vlan tx support for
>> tuntap. This is done by copying vlan header directly into userspace in
>> tun_put_user() instead of doing it through __vlan_put_tag() in
>> dev_hard_start_xmit(). This eliminates one unnecessary memove in
>> vlan_insert_tag() for 802.1ad and 802.1q traffic.
>>
>> pktgen test shows about 20% improvement for 802.1q traffic:
>>
>> Before:
>> 662149pps 317Mb/sec (317831520bps) errors: 0
>> After:
>> 801033pps 384Mb/sec (384495840bps) errors: 0
>>
>> Cc: Basil Gor <basil.gor@gmail.com>
>> Cc: Michael S. Tsirkin <mst@redhat.com>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>
> You need to make this configurable by some mechanism, since otherwise
> it will break applications that expect current VLAN behavior
> --
>
Didn't see any breakage. Vlan id will always exist in the userspace buffer.
next prev parent reply other threads:[~2013-07-24 4:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 7:15 [PATCH net-next] tuntap: hardware vlan tx support Jason Wang
2013-07-23 12:12 ` Sergei Shtylyov
2013-07-24 3:19 ` Jason Wang
2013-07-23 15:17 ` Stephen Hemminger
2013-07-23 15:27 ` Michael S. Tsirkin
2013-07-24 4:41 ` Jason Wang [this message]
2013-07-23 15:53 ` Stephen Hemminger
2013-07-24 5:55 ` Jason Wang
2013-07-24 15:11 ` Stephen Hemminger
2013-07-25 3:31 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EF5B00.7040109@redhat.com \
--to=jasowang@redhat.com \
--cc=basil.gor@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.