From: Jason Wang <jasowang@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
gleb@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] x86: introduce hypervisor_cpuid_base()
Date: Wed, 24 Jul 2013 12:44:30 +0800 [thread overview]
Message-ID: <51EF5BAE.1020905@redhat.com> (raw)
In-Reply-To: <51EEA96D.3070208@zytor.com>
On 07/24/2013 12:03 AM, H. Peter Anvin wrote:
> On 07/23/2013 04:16 AM, Paolo Bonzini wrote:
>> That's nicer, though strcmp is what the replaced code used to do in
>> patches 2 and 3.
>>
>> Note that memcmp requires the caller to use "KVMKVMKVM\0\0" as the
>> signature (or alternatively hypervisor_cpuid_base can copy the argument
>> into another 12-byte local variable).
>>
> Which is the actual signature, though...
>
> -hpa
>
>
Since it's just a minor optimization. How about just keep using the
strcmp()?
next prev parent reply other threads:[~2013-07-24 4:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 9:41 [PATCH 1/4] x86: introduce hypervisor_cpuid_base() Jason Wang
2013-07-23 9:41 ` [PATCH 2/4] xen: switch to use hypervisor_cpuid_base() Jason Wang
2013-07-23 9:41 ` Jason Wang
2013-07-23 11:16 ` Paolo Bonzini
2013-07-23 11:16 ` Paolo Bonzini
2013-07-23 15:55 ` Konrad Rzeszutek Wilk
2013-07-23 15:55 ` Konrad Rzeszutek Wilk
2013-07-23 9:41 ` [PATCH 3/4] kvm: " Jason Wang
2013-07-23 11:16 ` Paolo Bonzini
2013-07-23 9:41 ` [PATCH 4/4] x86: properly handle kvm emulation of hyperv Jason Wang
2013-07-23 11:17 ` Paolo Bonzini
2013-07-23 13:55 ` KY Srinivasan
2013-07-23 14:48 ` H. Peter Anvin
2013-07-23 17:45 ` KY Srinivasan
2013-07-23 18:45 ` H. Peter Anvin
2013-07-23 22:42 ` KY Srinivasan
2013-07-24 4:37 ` Jason Wang
2013-07-24 4:48 ` H. Peter Anvin
2013-07-24 6:54 ` Jason Wang
2013-07-24 7:06 ` Paolo Bonzini
2013-07-24 14:01 ` KY Srinivasan
2013-07-24 15:14 ` H. Peter Anvin
2013-07-24 19:05 ` KY Srinivasan
2013-07-24 19:05 ` KY Srinivasan
2013-07-24 21:37 ` H. Peter Anvin
2013-07-25 7:59 ` Paolo Bonzini
2013-07-25 8:12 ` Jason Wang
2013-07-23 10:04 ` [PATCH 1/4] x86: introduce hypervisor_cpuid_base() H. Peter Anvin
2013-07-23 11:16 ` Paolo Bonzini
2013-07-23 16:03 ` H. Peter Anvin
2013-07-24 4:44 ` Jason Wang [this message]
2013-07-24 4:47 ` H. Peter Anvin
2013-07-23 13:48 ` Gleb Natapov
2013-07-24 4:34 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EF5BAE.1020905@redhat.com \
--to=jasowang@redhat.com \
--cc=gleb@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.