From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751485Ab3GXFzp (ORCPT ); Wed, 24 Jul 2013 01:55:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41876 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750843Ab3GXFzo (ORCPT ); Wed, 24 Jul 2013 01:55:44 -0400 Message-ID: <51EF6C42.1070304@redhat.com> Date: Wed, 24 Jul 2013 13:55:14 +0800 From: Jason Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Stephen Hemminger CC: davem@davemloft.net, mst@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Basil Gor Subject: Re: [PATCH net-next] tuntap: hardware vlan tx support References: <1374563748-38821-1-git-send-email-jasowang@redhat.com> <20130723085310.4a036a47@nehalam.linuxnetplumber.net> In-Reply-To: <20130723085310.4a036a47@nehalam.linuxnetplumber.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/23/2013 11:53 PM, Stephen Hemminger wrote: > On Tue, 23 Jul 2013 15:15:48 +0800 > Jason Wang wrote: > >> + struct { >> + __be16 h_vlan_proto; >> + __be16 h_vlan_TCI; >> + } veth; > Don't you want to use struct vlan_hdr here? There's no need to care encapsulated proto here. In fact, we just emulate the hardware inserting of 802.1Q header. So only skb->vlan_tci and skb->vlan_proto needs to be cared. > Your definition puts the two fields out of order? It's order is same as struct vlan_ethhdr. Did you see any issue?