Re: [PATCH 2/4] mtd: nand: refactor chip->block_markbad interface

[Huang Shijie <b32955@freescale.com>]

于 2013年07月24日 14:27, Brian Norris 写道:
> The chip->block_markbad pointer should really only be responsible for
> writing a bad block marker for new bad blocks. It should not take care
> of BBT-related functionality, nor should it handle bookkeeping of bad
> block stats.
yes.
the gpmi driver should not do the BBT-related jobs.

> This patch refactors the 3 users of the block_markbad interface (plus
> the default nand_base implementation) so that the common code is kept in
> nand_block_markbad_lowlevel(). It removes some inconsistencies between
> the various implementations and should allow for more centralized
> improvements in the future.
>
> Because gpmi-nand no longer needs the nand_update_bbt() function, let's
> stop exporting it as well.
for the gpmi-nand part:
Acked-by: Huang Shijie <b32955@freescale.com>

thanks
Huang Shijie