Re: [Qemu-devel] [PATCH v2 01/11] target-ppc: Convert ppc cpu savevm to VMStateDescription

["Andreas Färber" <afaerber@suse.de>]

Am 24.07.2013 10:16, schrieb Alexey Kardashevskiy:
> On 07/19/2013 05:32 AM, Anthony Liguori wrote:
>> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
>> index 79bfcd8..09ea944 100644
>> --- a/target-ppc/translate_init.c
>> +++ b/target-ppc/translate_init.c
>> @@ -8449,6 +8449,8 @@ static void ppc_cpu_class_init(ObjectClass *oc, void *data)
>>      cc->do_interrupt = ppc_cpu_do_interrupt;
>>      cc->dump_state = ppc_cpu_dump_state;
>>      cc->dump_statistics = ppc_cpu_dump_statistics;
>> +
>> +    cpu_class_set_vmsd(cc, &vmstate_ppc_cpu);
>>  }
> 
> 
> Does not apply on the current master from qemu.org, need this:
> 
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index f97c0c7..f377b74 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -8462,7 +8462,7 @@ static void ppc_cpu_class_init(ObjectClass *oc, void
> *data)
>      cc->get_phys_page_debug = ppc_cpu_get_phys_page_debug;
>  #endif
> 
> -    cpu_class_set_vmsd(cc, &vmstate_ppc_cpu);
> +    dc->vmsd = &vmstate_ppc_cpu;
>  }
> 
>  static const TypeInfo ppc_cpu_type_info = {

That would break ppc-linux-user. It needs to go into the #ifdef above,
which obsoleted cpu_class_set_vmsd().

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg