Re: [Qemu-devel] [PATCH] RFC v2: hcd-ohci: add dma error handling

[Gerd Hoffmann <kraxel@redhat.com>]

> +/** A typical O/EHCI will stop operating, set itself into error state
> + * (which can be queried by MMIO) and will set PERR in its config
> + * space to signal that it got an error
> + */
> +static void ohci_stop(OHCIState *ohci)
> +{
> +    OHCIPCIState *dev = container_of(ohci, OHCIPCIState, state);
> +
> +    fprintf(stderr, "%s: DMA error\n", __func__);
> +
> +    ohci_set_interrupt(ohci, OHCI_INTR_UE);
> +    pci_set_word(dev->parent_obj.config + PCI_STATUS,
> +                 PCI_STATUS_DETECTED_PARITY);
> +}

I think you want add a ohci_bus_stop() call here to make sure the ohci
emulation stops processing.

Also while being at it: ohci_bus_start() has a TODO item where you can
fill in a call to the new ohci_stop function.

cheers,
  Gerd