From: Richard Henderson <rth@twiddle.net>
To: riku.voipio@linaro.org
Cc: qemu-devel@nongnu.org, Laurent Vivier <laurent@vivier.eu>
Subject: Re: [Qemu-devel] [RFC] [PATCH] linux-user: implement m68k atomic syscalls
Date: Wed, 24 Jul 2013 08:43:53 -1000 [thread overview]
Message-ID: <51F02069.8050301@twiddle.net> (raw)
In-Reply-To: <1374649831-5656-1-git-send-email-riku.voipio@linaro.org>
On 07/23/2013 09:10 PM, riku.voipio@linaro.org wrote:
> +#ifdef TARGET_NR_atomic_cmpxchg_32
> + case TARGET_NR_atomic_cmpxchg_32:
> + {
> + /* should use start_exclusive from main.c */
> + abi_ulong mem_value;
> + if (get_user_u32(mem_value, arg6))
> + ret = -TARGET_EFAULT;
> + if (mem_value == arg2)
> + put_user_u32(arg1, arg6);
> + ret = mem_value;
> + break;
> + }
The ret = -TARGET_FAULT doesn't do anything useful
without an associated break.
The kernel queues the expected SIGSEGV for this sort
of failure. Would that happen here?
r~
prev parent reply other threads:[~2013-07-24 18:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 7:10 [Qemu-devel] [RFC] [PATCH] linux-user: implement m68k atomic syscalls riku.voipio
2013-07-24 18:43 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F02069.8050301@twiddle.net \
--to=rth@twiddle.net \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.