From: Tony Asleson <tasleson@redhat.com>
To: lvm-devel@redhat.com
Subject: master - cleanup: lvm complient style
Date: Wed, 24 Jul 2013 17:36:26 -0500 [thread overview]
Message-ID: <51F056EA.3010403@redhat.com> (raw)
In-Reply-To: <20130722104212.0008361478@fedorahosted.org>
On 07/22/2013 05:42 AM, Zdenek Kabelac wrote:
> Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=d4ad728610db1751af1eab2c8c7d6130a3742394
> Commit: d4ad728610db1751af1eab2c8c7d6130a3742394
> Parent: 05a70f2da306164f3c604c50d69e74090b0028bc
> Author: Zdenek Kabelac <zkabelac@redhat.com>
> AuthorDate: Fri Jul 19 15:33:26 2013 +0200
> Committer: Zdenek Kabelac <zkabelac@redhat.com>
> CommitterDate: Mon Jul 22 12:41:21 2013 +0200
>
> cleanup: lvm complient style
>
> drop unused assignments.
...
> /* Each call to PyModule_AddObject decrefs it; compensate: */
> - Py_INCREF(LibLVMError);
> - Py_INCREF(LibLVMError);
> - PyModule_AddObject(m, "error", LibLVMError);
> - PyModule_AddObject(m, "LibLVMError", LibLVMError);
> + Py_INCREF(_LibLVMError);
> + Py_INCREF(_LibLVMError);
> + PyModule_AddObject(m, "error", _LibLVMError);
> + PyModule_AddObject(m, "_LibLVMError", _LibLVMError);
This changed the visible exception from LibLVMError to _LibLVMError
which breaks existing python code.
Regards,
Tony
next prev parent reply other threads:[~2013-07-24 22:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 10:42 master - cleanup: lvm complient style Zdenek Kabelac
2013-07-24 22:36 ` Tony Asleson [this message]
2013-07-25 9:17 ` Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F056EA.3010403@redhat.com \
--to=tasleson@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.