From: Ryan Mallon <rmallon@gmail.com>
To: Prashant Shah <pshah.mumbai@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
mwhitehe@redhat.com, kernel-mentors@selenic.com
Subject: Re: [PATCH] Change request_irq() to use struct net_device *dev->name
Date: Thu, 25 Jul 2013 10:42:49 +1000 [thread overview]
Message-ID: <51F07489.7010404@gmail.com> (raw)
In-Reply-To: <1374646199-9398-1-git-send-email-pshah.mumbai@gmail.com>
On 24/07/13 16:09, Prashant Shah wrote:
> Signed-off-by: Prashant Shah <pshah.mumbai@gmail.com>
> ---
> drivers/net/ethernet/8390/wd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/8390/wd.c b/drivers/net/ethernet/8390/wd.c
> index 03eb3ee..b43a63f 100644
> --- a/drivers/net/ethernet/8390/wd.c
> +++ b/drivers/net/ethernet/8390/wd.c
> @@ -308,7 +308,7 @@ static int __init wd_probe1(struct net_device *dev, int ioaddr)
>
> /* Snarf the interrupt now. There's no point in waiting since we cannot
> share and the board will usually be enabled. */
> - i = request_irq(dev->irq, ei_interrupt, 0, DRV_NAME, dev);
> + i = request_irq(dev->irq, ei_interrupt, 0, dev->name, dev);
You should also remove the definition of DRV_NAME, since it is no longer
used. The changelog should probably mention that this will change the
interrupt name (which appears in /proc/interrupts for example) from "wd"
to "eth%d".
~Ryan
next prev parent reply other threads:[~2013-07-25 0:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 6:09 [PATCH] Change request_irq() to use struct net_device *dev->name Prashant Shah
2013-07-24 6:09 ` Prashant Shah
2013-07-25 0:42 ` Ryan Mallon [this message]
2013-07-25 5:19 ` Prashant Shah
2013-07-25 5:19 ` Prashant Shah
2013-07-25 5:38 ` Prashant Shah
2013-07-25 5:38 ` Prashant Shah
2013-07-25 12:16 ` Andy Shevchenko
2013-07-25 15:20 ` tedheadster
2013-07-25 18:31 ` Andy Shevchenko
2013-07-25 18:33 ` Sergei Shtylyov
2013-07-25 18:38 ` Aaro Koskinen
2013-07-27 8:58 ` Prashant Shah
2013-07-27 8:58 ` Prashant Shah
2013-07-27 15:13 ` Sergei Shtylyov
2013-07-27 15:13 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F07489.7010404@gmail.com \
--to=rmallon@gmail.com \
--cc=kernel-mentors@selenic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mwhitehe@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshah.mumbai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.