From: Tushar Behera <tushar.behera@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH] gpio_msm: Fix build error due to missing err.h
Date: Thu, 25 Jul 2013 09:11:58 +0530 [thread overview]
Message-ID: <51F09E86.1010401@linaro.org> (raw)
In-Reply-To: <1374697248-23401-1-git-send-email-sboyd@codeaurora.org>
On 07/25/2013 01:50 AM, Stephen Boyd wrote:
> drivers/gpio/gpio-msm-v1.c: In function 'gpio_msm_v1_probe':
> drivers/gpio/gpio-msm-v1.c:656:2:
> error: implicit declaration of function 'IS_ERR'
> [-Werror=implicit-function-declaration]
> drivers/gpio/gpio-msm-v1.c:657:3:
> error: implicit declaration of function 'PTR_ERR'
> [-Werror=implicit-function-declaration]
>
> This driver failed to compile after commit 68515bb
> (gpio_msm: Convert to use devm_ioremap_resource,
> 2013-06-10).
>
> Cc: Tushar Behera <tushar.behera@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Sorry for this. I must have messed up while testing this patchset.
Acked-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> drivers/gpio/gpio-msm-v1.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-msm-v1.c b/drivers/gpio/gpio-msm-v1.c
> index e3ceaac..73b7396 100644
> --- a/drivers/gpio/gpio-msm-v1.c
> +++ b/drivers/gpio/gpio-msm-v1.c
> @@ -21,6 +21,7 @@
> #include <linux/module.h>
> #include <linux/device.h>
> #include <linux/platform_device.h>
> +#include <linux/err.h>
>
> #include <mach/msm_gpiomux.h>
>
>
--
Tushar Behera
next prev parent reply other threads:[~2013-07-25 3:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 20:20 [PATCH] gpio_msm: Fix build error due to missing err.h Stephen Boyd
2013-07-25 3:41 ` Tushar Behera [this message]
2013-07-29 15:37 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F09E86.1010401@linaro.org \
--to=tushar.behera@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.