Re: [PATCH 3/3] libxc: add xc_tbuf_trace() to insert trace records

[David Vrabel <david.vrabel@citrix.com>]

On 25/07/13 14:23, David Vrabel wrote:
> From: David Vrabel <david.vrabel@citrix.com>
> 
> Add xc_tbuf_trace() to allow trace records to be added to the trace
> buffer.  The subclass and event number and up to 7 uin32_t arguments
> may be specified.
> 
> The hypercall sub-op used is HVMOP_xentrace which (despite the name)
> may be used by PV guests.
> 
[...]
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -4388,7 +4388,7 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) arg)
>              return -EFAULT;
>  
>          if ( tr.extra_bytes > sizeof(tr.extra)
> -             || (tr.event & ~((1u<<TRC_CLS_SHIFT)-1)) )
> +             || (tr.event & ~((1u<<TRC_SUBCLS_SHIFT)-1)) )
>              return -EINVAL;
>  
>          trace_var(TRC_GUEST_EVENT(tr.event), 1 /*cycles*/,

This hunk shouldn't be here. I made a mistake when refactoring the series.

David