From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chad Versace Subject: Re: [PATCH 1/2] drm/i915: split PCI IDs out into i915_drm.h v3 Date: Thu, 25 Jul 2013 09:55:50 -0700 Message-ID: <51F15896.3010601@linux.intel.com> References: <1374710683-2614-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 316B0E611F for ; Thu, 25 Jul 2013 09:56:06 -0700 (PDT) In-Reply-To: <1374710683-2614-1-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 07/24/2013 05:04 PM, Jesse Barnes wrote: > For use by userspace (at some point in the future) and other kernel code. > > v2: move PCI IDs to uabi (Chris) > move PCI IDs to drm/ (Dave) > v3: fixup Quanta detection - needs to come first (Daniel) > > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/i915_drv.c | 164 +++++++----------------------- > include/drm/i915_drm.h | 2 + > include/drm/i915_pciids.h | 208 +++++++++++++++++++++++++++++++++++++++ > 3 files changed, 244 insertions(+), 130 deletions(-) > create mode 100644 include/drm/i915_pciids.h > +#define INTEL_VGA_DEVICE(id, info) { \ > + .class = PCI_BASE_CLASS_DISPLAY << 16, \ > + .class_mask = 0xff0000, \ > + .vendor = 0x8086, \ > + .device = id, \ > + .subvendor = PCI_ANY_ID, \ > + .subdevice = PCI_ANY_ID, \ > + .driver_data = (unsigned long) info } I retract my objections from yesterday. I expected the header to define a static table (like static const struct xxx i915_pci_ids[] = ...), which I didn't like due its inflexibility. But, this macro I do like. It's flexible enough. Acked-by: Chad Versace