All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vitaly E. Lavrov" <lve@guap.ru>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net
Subject: [PATCH] veth: remove hardware checksum feature
Date: Thu, 25 Jul 2013 21:20:16 +0400	[thread overview]
Message-ID: <51F15E50.8080208@guap.ru> (raw)

The network device VETH can't support the feature NETIF_F_HW_CSUM.
All locally generated packets have invalid checksum.
Wrong commit http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=8093315a91340bca52549044975d8c7f673b28a1 ( 
kernel 3.9.0 )

Workaround "ethtool -K vethX tx off"

Possible patch:

diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index 177f911..3db97da 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -254,7 +254,7 @@ static const struct net_device_ops veth_netdev_ops = {
  };

  #define VETH_FEATURES (NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_ALL_TSO |    \
-                      NETIF_F_HW_CSUM | NETIF_F_RXCSUM | NETIF_F_HIGHDMA | \
+                      NETIF_F_RXCSUM | NETIF_F_HIGHDMA | \
                        NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_HW_VLAN_CTAG_RX | \
                        NETIF_F_HW_VLAN_STAG_TX | NETIF_F_HW_VLAN_STAG_RX )
--

             reply	other threads:[~2013-07-25 17:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 17:20 Vitaly E. Lavrov [this message]
2013-07-25 17:59 ` [PATCH] veth: remove hardware checksum feature Eric Dumazet
2013-08-08  0:07 ` Ben Greear
2013-08-08  0:12   ` Eric Dumazet
2013-08-08  0:23     ` Ben Greear
2013-08-08  1:08       ` Eric Dumazet
2013-08-08  1:54         ` Ben Greear
2013-08-08  2:52           ` Eric Dumazet
2013-08-08 19:43             ` Ben Greear
2013-08-08 20:16               ` Eric Dumazet
2013-08-08 22:13                 ` Ben Greear
2013-08-08 22:20                   ` Ben Greear
2013-08-08 22:22                   ` Eric Dumazet
2013-08-08 22:35                     ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F15E50.8080208@guap.ru \
    --to=lve@guap.ru \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.