From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2RyD-0004cu-TJ for qemu-devel@nongnu.org; Thu, 25 Jul 2013 16:17:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2Ry9-0004Y7-Si for qemu-devel@nongnu.org; Thu, 25 Jul 2013 16:17:05 -0400 From: Don Koch Message-ID: <51F18748.8090305@terremark.com> Date: Thu, 25 Jul 2013 16:15:04 -0400 MIME-Version: 1.0 References: <1374532568-28051-1-git-send-email-afaerber@suse.de> <1374532568-28051-2-git-send-email-afaerber@suse.de> In-Reply-To: <1374532568-28051-2-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH qom-next v2 1/4] pci-bridge: Turn PCIBridge into abstract QOM type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Alexander Graf , New World , qemu-devel@nongnu.org, "Michael S. Tsirkin" On 07/22/2013 06:36 PM, Andreas Färber wrote: > Introduce TYPE_PCI_BRIDGE as base type and use PCI_BRIDGE() casts. > > Signed-off-by: Andreas Färber > --- > hw/pci-bridge/dec.c | 4 ++-- > hw/pci-bridge/i82801b11.c | 6 +++--- > hw/pci-bridge/ioh3420.c | 18 ++++++++--------- > hw/pci-bridge/pci_bridge_dev.c | 10 +++++----- > hw/pci-bridge/xio3130_downstream.c | 18 ++++++++--------- > hw/pci-bridge/xio3130_upstream.c | 19 +++++++++--------- > hw/pci-host/apb.c | 4 ++-- > hw/pci/pci.c | 2 +- > hw/pci/pci_bridge.c | 40 +++++++++++++++++++++++++++----------- > hw/pci/pcie.c | 2 +- > include/hw/pci/pci_bus.h | 7 ++++++- > 11 files changed, 77 insertions(+), 53 deletions(-) Saved me the trouble of doing this myself. Thanks! ;) Reviewed-by: Don Koch