From: Paolo Bonzini <pbonzini@redhat.com>
To: Ian Main <imain@redhat.com>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, rjones@redhat.com
Subject: Re: [Qemu-devel] [PATCH V7 1/2] Implement sync modes for drive-backup.
Date: Fri, 26 Jul 2013 08:58:16 +0200 [thread overview]
Message-ID: <51F21E08.8060109@redhat.com> (raw)
In-Reply-To: <1374800982-2818-2-git-send-email-imain@redhat.com>
Il 26/07/2013 03:09, Ian Main ha scritto:
> + /* See if we have a backing HD we can use to create our new image
> + * on top of. */
> + source = bs->backing_hd;
> + if (!source && sync == MIRROR_SYNC_MODE_TOP) {
> + sync = MIRROR_SYNC_MODE_FULL;
> + }
> +
I understand why you left out the "magic" backing file manipulation, but
source should still be "bs" for MIRROR_SYNC_MODE_NONE.
Paolo
next prev parent reply other threads:[~2013-07-26 6:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 1:09 [Qemu-devel] [PATCH V7 0/2] Implement sync modes for drive-backup Ian Main
2013-07-26 1:09 ` [Qemu-devel] [PATCH V7 1/2] " Ian Main
2013-07-26 6:58 ` Paolo Bonzini [this message]
2013-07-26 17:15 ` Ian Main
2013-07-26 1:09 ` [Qemu-devel] [PATCH V7 2/2] Add tests for sync modes 'TOP' and 'NONE' Ian Main
2013-07-26 16:58 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F21E08.8060109@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=imain@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.