From: Gerd Hoffmann <kraxel@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] hcd-ohci: add dma error handling
Date: Fri, 26 Jul 2013 11:58:38 +0200 [thread overview]
Message-ID: <51F2484E.4020308@redhat.com> (raw)
In-Reply-To: <1374829812-5201-1-git-send-email-aik@ozlabs.ru>
On 07/26/13 11:10, Alexey Kardashevskiy wrote:
> Current hcd-ohci does not handle DMA errors. However they may happen
> so here we introduce simple error handling.
>
> On such errors, a typical OHCI will stop operating, signal the guest
> about the error by sending "UnrecoverableError Event", set itself into
> error state and set "Detected Parity Error" in its PCI config space
> to signal that it got an error and so does the patch.
>
> This also adds ohci_stop() call to ohci_bus_start() to handle possible
> failure of qemu_new_timer_ns().
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Looks sane to me now. When I get an ack from Benjamin I'll go put it
into the usb patch queue.
cheers,
Gerd
next prev parent reply other threads:[~2013-07-26 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 9:10 [Qemu-devel] [PATCH v3] hcd-ohci: add dma error handling Alexey Kardashevskiy
2013-07-26 9:58 ` Gerd Hoffmann [this message]
2013-07-26 10:10 ` Benjamin Herrenschmidt
2013-07-26 10:23 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F2484E.4020308@redhat.com \
--to=kraxel@redhat.com \
--cc=aik@ozlabs.ru \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.