All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4] hcd-ohci: add dma error handling
Date: Fri, 26 Jul 2013 12:43:03 +0200	[thread overview]
Message-ID: <51F252B7.5060409@redhat.com> (raw)
In-Reply-To: <1374835075-14659-1-git-send-email-aik@ozlabs.ru>

  Hi,

> This also adds ohci_stop() call to ohci_bus_start() to handle possible
> failure of qemu_new_timer_ns().

> * ohci_stop renamed to ohci_die to describe the action better

Except in the commit message ...

Also scripts/checkpatch.pl complains:

ERROR: return is not a function, parentheses are not required
#90: FILE: hw/usb/hcd-ohci.c:590:
+    return (get_dwords(ohci, addr, (uint32_t *)td, 4) ||

ERROR: return is not a function, parentheses are not required
#109: FILE: hw/usb/hcd-ohci.c:622:
+    return (put_dwords(ohci, addr, (uint32_t *)td, 4) ||

We are almost there now ;)

cheers,
  Gerd

      reply	other threads:[~2013-07-26 10:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-26 10:37 [Qemu-devel] [PATCH v4] hcd-ohci: add dma error handling Alexey Kardashevskiy
2013-07-26 10:43 ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F252B7.5060409@redhat.com \
    --to=kraxel@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.