From: Matt Fleming <matt.fleming@intel.com>
To: Roy Franz <roy.franz@linaro.org>
Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
x86@kernel.org, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] correct call to free_pages to specify memory size in pages, not bytes.
Date: Fri, 26 Jul 2013 15:58:53 +0100 [thread overview]
Message-ID: <51F28EAD.2080705@intel.com> (raw)
In-Reply-To: <1374713324-23670-2-git-send-email-roy.franz@linaro.org>
On 25/07/13 01:48, Roy Franz wrote:
> Signed-off-by: Roy Franz <roy.franz@linaro.org>
> ---
> arch/x86/boot/compressed/eboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
> index d606463..b7388a4 100644
> --- a/arch/x86/boot/compressed/eboot.c
> +++ b/arch/x86/boot/compressed/eboot.c
> @@ -225,7 +225,7 @@ static void low_free(unsigned long size, unsigned long addr)
> unsigned long nr_pages;
>
> nr_pages = round_up(size, EFI_PAGE_SIZE) / EFI_PAGE_SIZE;
> - efi_call_phys2(sys_table->boottime->free_pages, addr, size);
> + efi_call_phys2(sys_table->boottime->free_pages, addr, nr_pages);
> }
>
> static void find_bits(unsigned long mask, u8 *pos, u8 *size)
Thanks Roy. I pulled this into my urgent queue, as it's obviously a bug
and I don't fancy our chances if we ask the firmware to free more memory
than it initially allocated.
prev parent reply other threads:[~2013-07-26 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 0:48 [PATCH] correct call to free_pages to specify memory size in pages, not bytes Roy Franz
2013-07-25 0:48 ` Roy Franz
2013-07-25 0:48 ` Roy Franz
2013-07-26 14:58 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F28EAD.2080705@intel.com \
--to=matt.fleming@intel.com \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=roy.franz@linaro.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.