From: Lars-Peter Clausen <lars@metafoo.de>
To: Stephen Warren <swarren@wwwdotorg.org>, Bard Liao <bardliao@realtek.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Broken headphone and speaker amplifier supplies for the rt5640 driver
Date: Fri, 26 Jul 2013 17:06:12 +0200 [thread overview]
Message-ID: <51F29064.8080003@metafoo.de> (raw)
Hi,
The rt5640 driver sets for both the headphone and speaker amplifier widget
the shift to SND_SOC_NOPM, which is -1. This doesn't make much sense and
breaks compilation with some changes I've made.
I guess for the heaphone amplifier the right fix is to set the shift to
RT5640_PWR_HA_BIT. For the speaker amplifier I'd assume that the right bit
is RT5640_PWR_CLS_D_BIT. But the speaker amplifier widget also as an event
callback in which it already seems to set/clear the bit. I think the right
fix is to remove the register change from the event callback and set the
shift to RT5640_PWR_CLS_D_BIT. But I neither have the hardware nor the
datasheet, so this is all just an educated guess.
- Lars
next reply other threads:[~2013-07-26 15:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 15:06 Lars-Peter Clausen [this message]
2013-07-26 16:57 ` Broken headphone and speaker amplifier supplies for the rt5640 driver Stephen Warren
2013-07-27 17:35 ` Mark Brown
2013-07-29 3:04 ` Broken headphone and speaker amplifier suppliesforthe " Bard Liao
2013-07-29 6:07 ` Mark Brown
2013-07-29 6:14 ` Lars-Peter Clausen
2013-07-29 6:45 ` Mark Brown
[not found] ` <201307290148.r6T1mLk1013980@rtits1.realtek.com>
2013-07-29 2:48 ` Bard Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F29064.8080003@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.