All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Ben Myers <bpm@sgi.com>
Cc: linxu-btrfs@vger.kernel.org, Josef Bacik <jbacik@fusionio.com>,
	xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: exit out if _scratch_mount fails
Date: Fri, 26 Jul 2013 11:15:13 -0500	[thread overview]
Message-ID: <51F2A091.3010407@sandeen.net> (raw)
In-Reply-To: <20130726161235.GK3111@sgi.com>

On 7/26/13 11:12 AM, Ben Myers wrote:
> Hey Josef,
> 
> On Tue, Jul 09, 2013 at 03:07:27PM -0400, Josef Bacik wrote:
>> I test some of the different mkfs options for btrfs, one set doesn't work
>> properly with small file systems, so the fs won't mount.  This is fine from a
>> btrfs point of view, but tests that fail to mount the scratch fs will run
>> anyway, so if it's a "fill the fs" sort of test this will wreak havoc.  To fix
>> this just error out of _scratch_mount fails.  Thanks,
>>
>> Signed-off-by: Josef Bacik <jbacik@fusionio.com>
> 
> I noticed that this change causes dmapi tests to try to be run on systems that
> don't have dmapi supported, and they fail.  Have you seen this?
> 
> Thanks,
> 	Ben

I haven't tested either way, but does:

     _mount -t $FSTYP `_scratch_mount_options $*` || _fail "Scratch mount failed"

work any better?

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-07-26 16:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-09 19:07 [PATCH] xfstests: exit out if _scratch_mount fails Josef Bacik
2013-07-19 20:38 ` Ben Myers
2013-07-26 16:12 ` Ben Myers
2013-07-26 16:15   ` Eric Sandeen [this message]
2013-07-26 16:25     ` Josef Bacik
2013-07-26 16:33     ` Ben Myers
2013-07-26 16:58       ` Eric Sandeen
2013-07-26 16:58         ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F2A091.3010407@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=bpm@sgi.com \
    --cc=jbacik@fusionio.com \
    --cc=linxu-btrfs@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.