From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: grant.likely@linaro.org, linus.walleij@linaro.org,
rob.herring@calxeda.com, rob@landley.net, sameo@linux.intel.com,
lee.jones@linaro.org, devicetree-discuss@lists.ozlabs.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
gg@slimlogic.co.uk, kishon@ti.com, swarren@nvidia.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: pinconf_generic: add utility functions for add map/configs
Date: Fri, 26 Jul 2013 11:36:04 -0600 [thread overview]
Message-ID: <51F2B384.9050706@wwwdotorg.org> (raw)
In-Reply-To: <1374833754-19659-2-git-send-email-ldewangan@nvidia.com>
On 07/26/2013 04:15 AM, Laxman Dewangan wrote:
> Some of pincontrol driver needs the utility function to create map
> list. The utility function needed for adding mux, configs etc.
Which other drivers already contain this code? Are you planning on
converting them over to use these new functions? The code looks
familiar, so I assume it's just cut/paste from Tegra with some renames,
so I didn't read it through in detail.
> drivers/pinctrl/pinconf-generic.c | 105 +++++++++++++++++++++++++++++++
> include/linux/pinctrl/pinconf-generic.h | 52 +++++++++++++++
I don't think those are the correct files for this code. Presumably
there's no reason at all why a pinctrl driver that doesn't require
CONFIG_GENERIC_PINCONF can't use these basic utility functions. Perhaps
add a new pinctrl-utils file?
next prev parent reply other threads:[~2013-07-26 17:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 10:15 [PATCH 0/2] pinctrl: palmas: add pincontrol driver Laxman Dewangan
2013-07-26 10:15 ` Laxman Dewangan
2013-07-26 10:15 ` [PATCH 1/2] pinctrl: pinconf_generic: add utility functions for add map/configs Laxman Dewangan
2013-07-26 10:15 ` Laxman Dewangan
2013-07-26 17:36 ` Stephen Warren [this message]
2013-07-27 10:14 ` Laxman Dewangan
2013-07-29 16:38 ` Stephen Warren
2013-08-07 18:27 ` Linus Walleij
2013-08-08 7:23 ` Laxman Dewangan
2013-07-26 10:15 ` [PATCH 2/2] pinctrl: palmas: add pincontrol driver Laxman Dewangan
2013-07-26 10:15 ` Laxman Dewangan
2013-07-26 16:41 ` Mark Brown
2013-07-27 10:23 ` Laxman Dewangan
2013-07-28 12:20 ` Mark Brown
2013-07-26 19:09 ` Stephen Warren
2013-07-27 12:11 ` Laxman Dewangan
2013-07-29 16:45 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F2B384.9050706@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=devicetree@vger.kernel.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@linaro.org \
--cc=kishon@ti.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sameo@linux.intel.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.