All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: "meta-freescale@yoctoproject.org" <meta-freescale@yoctoproject.org>
Subject: Re: [meta-fsl-arm][PATCH v2] gst-plugins-gl: Add dependencies on libjpeg, libpng
Date: Fri, 26 Jul 2013 11:43:45 -0700	[thread overview]
Message-ID: <51F2C361.9090503@boundarydevices.com> (raw)
In-Reply-To: <CAP9ODKrk0561c7Rwn71A542chk6-2VxHjm8twHqnqyrzhYLQtA@mail.gmail.com>

On 07/26/2013 11:33 AM, Otavio Salvador wrote:
> On Fri, Jul 26, 2013 at 3:17 PM, Eric Nelson
> <eric.nelson@boundarydevices.com> wrote:
>> On 07/26/2013 09:18 AM, Otavio Salvador wrote:
>>> I am sorry to didn't find this before but this is not a meta-fsl-arm
>>> specific fix. Instead this should be send to OE-Core and modify the
>>> .bb file.
>>>
>>> I checked the source:
>>>
>>> .../gst-plugins-gl-0.10.3% git grep ljpeg configure.ac
>>> configure.ac:JPEG_LIBS="$LIBS -ljpeg-mmx"
>>> configure.ac:  JPEG_LIBS="-ljpeg"
>>> .../gst-plugins-gl-0.10.3% git grep lpng configure.ac
>>> .../gst-plugins-gl-0.10.3% git grep png configure.ac
>>> configure.ac:dnl libpng is optional
>>> configure.ac:PKG_CHECK_MODULES(LIBPNG, libpng >= 1.0, HAVE_PNG=yes,
>>> HAVE_PNG=no)
>>> configure.ac:  AC_DEFINE(HAVE_PNG, [1] , [Use libpng])
>>>
>>
>> I'm going to need to re-test this. It looks like 'jpeg' is
>> already expressed as a dependency:
>>
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-multimedia/gstreamer/gst-plugins-gl_0.10.3.bb?h=dylan
>
> Yes; right.
>
> So it lacking png dependency; seems to be the only real issue here.
>

Well, maybe.

For some reason, neither libpng nor libjpeg was installed
in my rootfs.

I'll do a clean build and look more closely the next time.

I'm also confused about how things linked in the first place.

Both of those libraries must have been present during the
configure and build steps, but neither made into the
filesystem and I'm not sure why.

In my first attempt to pull in the gl-plugin, I added it
via local.conf. Perhaps that's the root cause and I'll
try to confirm things...

Regards,


Eric


  reply	other threads:[~2013-07-26 18:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-26 16:06 [meta-fsl-arm][PATCH v2] gst-plugins-gl: Add dependencies on libjpeg, libpng Eric Nelson
2013-07-26 16:17 ` Otavio Salvador
2013-07-26 16:18 ` Otavio Salvador
2013-07-26 18:17   ` Eric Nelson
2013-07-26 18:33     ` Otavio Salvador
2013-07-26 18:43       ` Eric Nelson [this message]
2013-07-28 16:00         ` Eric Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F2C361.9090503@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=meta-freescale@yoctoproject.org \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.