Re: [Qemu-devel] [PATCH 6/9] qapi.py: Fix schema parser to check syntax systematically

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]

On 07/26/2013 01:35 PM, Markus Armbruster wrote:

>>> +        if not self.tok in [ '{', '[', "'" ]:
>>> +            raise QAPISchemaError(self, 'Expected "{", "[", "]" or string')
>>
>> JSON allows primitives here, as in [ 1 ]; but I agree that for the
>> purposes of our schema we will always be taking a string or complex
>> object whenever we have a list.
> 
> The lexer doesn't recognize any atoms but strings.  If we change that,
> the syntax error messages need to be reviewed (not just this one).

Nah, I'm fine leaving the lexer as-is.  It's okay that we parse only a
subset of JSON, as long as our subset is expressive enough for our needs
in QAPI.

As it is, technically, we aren't QUITE parsing JSON, because our schema
strings are marked with '' instead of "".  And as long as we are
extending our parser to take something slightly different than JSON,
maybe we should teach it to tolerate trailing commas?  On the other
hand, the further we diverge from JSON, the more likely we are to have
to maintain the parser ourselves instead of being able to reuse someone
else's code.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]