From: Stephen Warren <swarren@wwwdotorg.org>
To: Andrew Chew <AChew@nvidia.com>
Cc: "rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ian.campbell@citrix.com" <ian.campbell@citrix.com>,
"rob@landley.net" <rob@landley.net>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"ian@slimlogic.co.uk" <ian@slimlogic.co.uk>,
"j-keerthy@ti.com" <j-keerthy@ti.com>,
"gg@slimlogic.co.uk" <gg@slimlogic.co.uk>,
Laxman Dewangan <ldewangan@nvidia.com>,
Rhyland Klein <rklein@nvidia.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: palmas: Add DVFS mux setting
Date: Fri, 26 Jul 2013 16:03:23 -0600 [thread overview]
Message-ID: <51F2F22B.500@wwwdotorg.org> (raw)
In-Reply-To: <643E69AA4436674C8F39DCC2C05F763862A1274113@HQMAIL03.nvidia.com>
On 07/26/2013 03:50 PM, Andrew Chew wrote:
>>>> How does this interact with the pinctrl driver that Laxman just sent
>>>> for Palmas?
>>>>
>>>> https://lkml.org/lkml/2013/7/26/141
>>>> [PATCH 0/2] pinctrl: palmas: add pincontrol driver
>>>
>>> Thanks for pointing this out. Given this:
>>>
>>> +Optional properties:
>>> +- ti,palams-enable-dvfs1: Enable DVFS1. Configure pins for DVFS1 mode.
>>> +- ti,palams-enable-dvfs2: Enable DVFS2. Configure pins for DVFS2 mode.
>>>
>>> I think his work already encompasses what my patch is supposed to do.
>>>
>>> Abandoning this patch.
>>
>> OK, that's simple!
>>
>> Are the existing ti,mux-pad1/ti,mux-pad2 properties already in the binding
>> redundant with Laxman's pinctrl driver?
>
> In linux-next (where I based my work), yes, those two properties already exist,
> and as far as I understand it, are redundant with Laxman's pinctrl driver.
> I expect those properties will go away with Laxman's pinctrl driver.
Except those properties have been there for many kernel revisions and
are an ABI and hence can't be removed, although I noticed that they got
renamed recently, and of course we aren't technically being strict about
this quite yet...
Re: the complete pinctrl driver: is anything outside the Palmas going to
need to reprogram the Palmas pinctrl HW at run-time? Are the functions
that can be routed to the pins just static configuration for PMIC
features, or might other generic (non-Palmas) drivers use those pins for
something? If not, perhaps it's be simpler to just add your ti,mux-pad3
property and be done.
next prev parent reply other threads:[~2013-07-26 22:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 20:41 [PATCH] mfd: palmas: Add DVFS mux setting Andrew Chew
2013-07-26 20:41 ` Andrew Chew
2013-07-26 21:17 ` Stephen Warren
2013-07-26 21:28 ` Andrew Chew
2013-07-26 21:38 ` Stephen Warren
2013-07-26 21:50 ` Andrew Chew
2013-07-26 22:03 ` Stephen Warren [this message]
2013-07-26 22:12 ` Andrew Chew
2013-07-27 9:55 ` Laxman Dewangan
2013-07-30 20:20 ` Stephen Warren
2013-07-30 20:53 ` Andrew Chew
2013-07-30 21:25 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F2F22B.500@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=AChew@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=ian@slimlogic.co.uk \
--cc=j-keerthy@ti.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rklein@nvidia.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.