From: Jan Kiszka <jan.kiszka@web.de>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-trivial] [PATCH] musicpal: Fix typo in name of local function
Date: Sun, 28 Jul 2013 08:17:49 +0200 [thread overview]
Message-ID: <51F4B78D.3010203@web.de> (raw)
In-Reply-To: <1374990895-25584-1-git-send-email-sw@weilnetz.de>
[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]
On 2013-07-28 07:54, Stefan Weil wrote:
> The misspelling was spotted by Andreas Färber.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/arm/musicpal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c
> index b06d442..ddddd27 100644
> --- a/hw/arm/musicpal.c
> +++ b/hw/arm/musicpal.c
> @@ -534,7 +534,7 @@ static void lcd_invalidate(void *opaque)
> {
> }
>
> -static void musicpal_lcd_gpio_brigthness_in(void *opaque, int irq, int level)
> +static void musicpal_lcd_gpio_brightness_in(void *opaque, int irq, int level)
> {
> musicpal_lcd_state *s = opaque;
> s->brightness &= ~(1 << irq);
> @@ -619,7 +619,7 @@ static int musicpal_lcd_init(SysBusDevice *dev)
> s->con = graphic_console_init(DEVICE(dev), &musicpal_gfx_ops, s);
> qemu_console_resize(s->con, 128*3, 64*3);
>
> - qdev_init_gpio_in(&dev->qdev, musicpal_lcd_gpio_brigthness_in, 3);
> + qdev_init_gpio_in(&dev->qdev, musicpal_lcd_gpio_brightness_in, 3);
>
> return 0;
> }
>
Reviewed-by: Jan Kiszka <jan.kiszka@web.de>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@web.de>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] musicpal: Fix typo in name of local function
Date: Sun, 28 Jul 2013 08:17:49 +0200 [thread overview]
Message-ID: <51F4B78D.3010203@web.de> (raw)
In-Reply-To: <1374990895-25584-1-git-send-email-sw@weilnetz.de>
[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]
On 2013-07-28 07:54, Stefan Weil wrote:
> The misspelling was spotted by Andreas Färber.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/arm/musicpal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c
> index b06d442..ddddd27 100644
> --- a/hw/arm/musicpal.c
> +++ b/hw/arm/musicpal.c
> @@ -534,7 +534,7 @@ static void lcd_invalidate(void *opaque)
> {
> }
>
> -static void musicpal_lcd_gpio_brigthness_in(void *opaque, int irq, int level)
> +static void musicpal_lcd_gpio_brightness_in(void *opaque, int irq, int level)
> {
> musicpal_lcd_state *s = opaque;
> s->brightness &= ~(1 << irq);
> @@ -619,7 +619,7 @@ static int musicpal_lcd_init(SysBusDevice *dev)
> s->con = graphic_console_init(DEVICE(dev), &musicpal_gfx_ops, s);
> qemu_console_resize(s->con, 128*3, 64*3);
>
> - qdev_init_gpio_in(&dev->qdev, musicpal_lcd_gpio_brigthness_in, 3);
> + qdev_init_gpio_in(&dev->qdev, musicpal_lcd_gpio_brightness_in, 3);
>
> return 0;
> }
>
Reviewed-by: Jan Kiszka <jan.kiszka@web.de>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2013-07-28 6:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-28 5:54 [Qemu-trivial] [PATCH] musicpal: Fix typo in name of local function Stefan Weil
2013-07-28 5:54 ` [Qemu-devel] " Stefan Weil
2013-07-28 6:17 ` Jan Kiszka [this message]
2013-07-28 6:17 ` Jan Kiszka
2013-07-28 9:46 ` [Qemu-trivial] " Andreas Färber
2013-07-28 9:46 ` Andreas Färber
2013-07-28 11:10 ` [Qemu-trivial] " Stefan Weil
2013-07-28 11:10 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F4B78D.3010203@web.de \
--to=jan.kiszka@web.de \
--cc=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.