From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH] ARM: EXYNOS: cpuidle: Skip C1 cpuidle state for exynos5440 Date: Sun, 28 Jul 2013 09:10:09 +0200 Message-ID: <51F4C3D1.2060901@linaro.org> References: <0e7d01ce8840$82f79070$88e6b150$@org> <1374659615-29447-1-git-send-email-amit.daniel@samsung.com> <0eaf01ce8863$89d3c4e0$9d7b4ea0$@org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wg0-f51.google.com ([74.125.82.51]:50338 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753210Ab3G1HKK (ORCPT ); Sun, 28 Jul 2013 03:10:10 -0400 Received: by mail-wg0-f51.google.com with SMTP id a12so214399wgh.30 for ; Sun, 28 Jul 2013 00:10:09 -0700 (PDT) In-Reply-To: <0eaf01ce8863$89d3c4e0$9d7b4ea0$@org> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Kukjin Kim Cc: 'Amit Daniel Kachhap' , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 'Thomas Abraham' On 07/24/2013 01:47 PM, Kukjin Kim wrote: > Amit Daniel Kachhap wrote: >> >> This patch skips the deep C1(AFTR -Arm off top running) state for >> exynos5440 >> soc as this soc does not support this state. All the cpu's only allo= ws the >> basic >> C0 state. >> >> Signed-off-by: Amit Daniel Kachhap >> --- >> arch/arm/mach-exynos/cpuidle.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach- >> exynos/cpuidle.c >> index 17a18ff..9a776a1 100644 >> --- a/arch/arm/mach-exynos/cpuidle.c >> +++ b/arch/arm/mach-exynos/cpuidle.c >> @@ -210,7 +210,7 @@ static int __init exynos4_init_cpuidle(void) >> device->cpu =3D cpu_id; >> >> /* Support IDLE only */ >> - if (cpu_id !=3D 0) >> + if (soc_is_exynos5440() || cpu_id !=3D 0) >> device->state_count =3D 1; >> >> ret =3D cpuidle_register_device(device); >> -- >> 1.7.1 >=20 > Applied, thanks. You shouldn't have. This patch means exynos5540 has no cpuidle driver a= t all. It should be fixed in the Kconfig to unselect CONFIG_CPU_IDLE for an exynos5540. --=20 Linaro.org =E2=94=82 Open source software for= ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Sun, 28 Jul 2013 09:10:09 +0200 Subject: [PATCH] ARM: EXYNOS: cpuidle: Skip C1 cpuidle state for exynos5440 In-Reply-To: <0eaf01ce8863$89d3c4e0$9d7b4ea0$@org> References: <0e7d01ce8840$82f79070$88e6b150$@org> <1374659615-29447-1-git-send-email-amit.daniel@samsung.com> <0eaf01ce8863$89d3c4e0$9d7b4ea0$@org> Message-ID: <51F4C3D1.2060901@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/24/2013 01:47 PM, Kukjin Kim wrote: > Amit Daniel Kachhap wrote: >> >> This patch skips the deep C1(AFTR -Arm off top running) state for >> exynos5440 >> soc as this soc does not support this state. All the cpu's only allows the >> basic >> C0 state. >> >> Signed-off-by: Amit Daniel Kachhap >> --- >> arch/arm/mach-exynos/cpuidle.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach- >> exynos/cpuidle.c >> index 17a18ff..9a776a1 100644 >> --- a/arch/arm/mach-exynos/cpuidle.c >> +++ b/arch/arm/mach-exynos/cpuidle.c >> @@ -210,7 +210,7 @@ static int __init exynos4_init_cpuidle(void) >> device->cpu = cpu_id; >> >> /* Support IDLE only */ >> - if (cpu_id != 0) >> + if (soc_is_exynos5440() || cpu_id != 0) >> device->state_count = 1; >> >> ret = cpuidle_register_device(device); >> -- >> 1.7.1 > > Applied, thanks. You shouldn't have. This patch means exynos5540 has no cpuidle driver at all. It should be fixed in the Kconfig to unselect CONFIG_CPU_IDLE for an exynos5540. -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog