From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3NuU-0001RY-Ew for qemu-devel@nongnu.org; Sun, 28 Jul 2013 06:09:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3NuO-0005ZY-Fh for qemu-devel@nongnu.org; Sun, 28 Jul 2013 06:09:06 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57309 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3NuO-0005YU-9N for qemu-devel@nongnu.org; Sun, 28 Jul 2013 06:09:00 -0400 Message-ID: <51F4EDB8.80806@suse.de> Date: Sun, 28 Jul 2013 12:08:56 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1374996553-21828-1-git-send-email-imammedo@redhat.com> <1374996553-21828-6-git-send-email-imammedo@redhat.com> In-Reply-To: <1374996553-21828-6-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 5/6] pc: add Q35 to QOM composition tree under /machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, mst@redhat.com Am 28.07.2013 09:29, schrieb Igor Mammedov: > Signed-off-by: Igor Mammedov > --- > hw/i386/pc_q35.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > index 0b1d2e3..5140caf 100644 > --- a/hw/i386/pc_q35.c > +++ b/hw/i386/pc_q35.c > @@ -130,7 +130,7 @@ static void pc_q35_init(QEMUMachineInitArgs *args) > =20 > /* create pci host bus */ > q35_host =3D Q35_HOST_DEVICE(qdev_create(NULL, TYPE_Q35_HOST_DEVIC= E)); > - > + object_property_add_child(qdev_get_machine(), "q35", OBJECT(q35_ho= st), NULL); > q35_host->mch.ram_memory =3D ram_memory; > q35_host->mch.pci_address_space =3D pci_memory; > q35_host->mch.system_memory =3D get_system_memory(); Reviewed-by: Andreas F=E4rber Thanks a lot, I was about to send the equivalent patch! This is a Last Minute guest-visible change, but it matches what we have for i440fx, so I consider this fine. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg