From: Stefan Weil <sw@weilnetz.de>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
Jan Kiszka <jan.kiszka@web.de>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] musicpal: Fix typo in name of local function
Date: Sun, 28 Jul 2013 13:10:23 +0200 [thread overview]
Message-ID: <51F4FC1F.6070803@weilnetz.de> (raw)
In-Reply-To: <51F4E884.4010509@suse.de>
Am 28.07.2013 11:46, schrieb Andreas Färber:
> Am 28.07.2013 07:54, schrieb Stefan Weil:
>> The misspelling was spotted by Andreas Färber.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>> hw/arm/musicpal.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
[...]
>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>>
>> but to clarify: I had notified you not to send this small patch, which
>> now conflicts with my argument cleanup, but to add this typo to your
>> blacklist to check the whole codebase for similar typos. Are there none?
>>
>> But since this is a sensible cleanup anyway, I'll just put a copy into
>> my queue before the refactoring, to avoid merge conflicts with -trivial.
>>
>> Thanks,
>> Andreas
Codespell uses a list of common misspellings which is an enhanced versionof
https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines.
"Brigthness" was not among those words. Even if it were, codespell would not
detect it in a composed word like musicpal_lcd_gpio_brigthness_in.
With some small modifications (split words at [-_]), codespell detects more
misspellings in QEMU: bandwith, issueing, propietary, threshhold.
Even more could be detected by analysing composed words.
Regards,
Stefan
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
Jan Kiszka <jan.kiszka@web.de>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] musicpal: Fix typo in name of local function
Date: Sun, 28 Jul 2013 13:10:23 +0200 [thread overview]
Message-ID: <51F4FC1F.6070803@weilnetz.de> (raw)
In-Reply-To: <51F4E884.4010509@suse.de>
Am 28.07.2013 11:46, schrieb Andreas Färber:
> Am 28.07.2013 07:54, schrieb Stefan Weil:
>> The misspelling was spotted by Andreas Färber.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>> hw/arm/musicpal.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
[...]
>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>>
>> but to clarify: I had notified you not to send this small patch, which
>> now conflicts with my argument cleanup, but to add this typo to your
>> blacklist to check the whole codebase for similar typos. Are there none?
>>
>> But since this is a sensible cleanup anyway, I'll just put a copy into
>> my queue before the refactoring, to avoid merge conflicts with -trivial.
>>
>> Thanks,
>> Andreas
Codespell uses a list of common misspellings which is an enhanced versionof
https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines.
"Brigthness" was not among those words. Even if it were, codespell would not
detect it in a composed word like musicpal_lcd_gpio_brigthness_in.
With some small modifications (split words at [-_]), codespell detects more
misspellings in QEMU: bandwith, issueing, propietary, threshhold.
Even more could be detected by analysing composed words.
Regards,
Stefan
next prev parent reply other threads:[~2013-07-28 11:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-28 5:54 [Qemu-trivial] [PATCH] musicpal: Fix typo in name of local function Stefan Weil
2013-07-28 5:54 ` [Qemu-devel] " Stefan Weil
2013-07-28 6:17 ` [Qemu-trivial] " Jan Kiszka
2013-07-28 6:17 ` [Qemu-devel] " Jan Kiszka
2013-07-28 9:46 ` [Qemu-trivial] " Andreas Färber
2013-07-28 9:46 ` Andreas Färber
2013-07-28 11:10 ` Stefan Weil [this message]
2013-07-28 11:10 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F4FC1F.6070803@weilnetz.de \
--to=sw@weilnetz.de \
--cc=afaerber@suse.de \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.